The fault object not available for some instances in ERROR state

[Łukasz Zemczak]

Recently we started getting spammed by failing autopkgtest-cloud/tools/cloud-worker-maintenance runs for 3 clouds. Some of the instances that were in the ERROR state and were waiting for getting deleted had no 'fault' object in them (which seems to be required by the openstack spec?).

Traceback (most recent call last):
  File "autopkgtest-cloud/tools/cleanup-instances", line 45, in <module>
    logging.warning('instance %s is in error state (message: %s), deleting', instance.name, str(instance.fault))
  File "/usr/lib/python3/dist-packages/novaclient/base.py", line 176, in __getattr__
    raise AttributeError(k)
AttributeError: fault

I have fixed that by making cleanup-instances handle the case of ERROR state instances with no fault details, but I guess this might be something needing additional investigation. Like, is this normal? What changed?

[Łukasz Zemczak (sil2100)]

It somehow feels like maybe indeed there can be some cases that there is no fault info on ERROR?

https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=0d0749d39ffd122387fde6ee5e9b029f93e53459

Or maybe this is some openstack bug we should report?

[Skia (hyask)]

Not happening anymore, and everything has changed since then.