quoted_string used in authres/core.py not defined

Bug #1165978 reported by Scott Kitterman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Authentication-Results-Python
Status tracked in Trunk
Trunk
Fix Released
High
Julian Mehnle

Bug Description

This issue caught by pyflakes

In _parse_pvalue, quoted_string is used twice but never defined. I fiddled with it, but I'm not sure what the correct thing is, so I'm filing a bug to document the issue.

Both uses are within the if quoted_string_match: branch of the code (line 577 with current trunk). This branch of the code is never exercised in the current tests. All the existing tests fail that check and go down the else branch (line 626 of current trunk).

I'm not sure if this means the code is never going to be exercised and should be removed, if something is wrong with quoted_string_match, or if we just need more tests to exercise this portion of the functionality.

Changed in authentication-results-python:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Julian Mehnle (jmehnle)
Revision history for this message
Scott Kitterman (kitterman) wrote :

Fixed in 0.601.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.