Activity log for bug #1838710

Date Who What changed Old value New value Message
2019-08-01 23:30:02 chipschap bug added bug
2019-08-02 00:01:41 chipschap description When initially running audio-recorder I was getting segfaults. I rebuilt from latest source, ran with gdb and found in utility.c around line 1049 gint str_compare(const gchar *s1, const gchar *s2, gboolean case_insensitive) { //rjn adds null checks if (*s1 == '\0' && *s2 == '\0') { // Equals return 0; etc. There is no check here for passing null pointers and somehow one got passed. So my temporary fix was this. I know it's not the right fix (s1 and s2 should be first tested outside of the if stmt) but it got around the problem. gint str_compare(const gchar *s1, const gchar *s2, gboolean case_insensitive) { if (s1 && (*s1 == '\0') && s2 && (*s2 == '\0')) { // Equals return 0; etc. My environment is Arch Linux (Antergos flavor). When initially running audio-recorder I was getting segfaults. I rebuilt from latest source, ran with gdb and found in utility.c around line 1049 gint str_compare(const gchar *s1, const gchar *s2, gboolean case_insensitive) {     if (*s1 == '\0' && *s2 == '\0') {         // Equals         return 0; etc. There is no check here for passing null pointers and somehow one got passed. So my temporary fix was this. I know it's not the right fix (s1 and s2 should be first tested outside of the if stmt) but it got around the problem. gint str_compare(const gchar *s1, const gchar *s2, gboolean case_insensitive) {     if (s1 && (*s1 == '\0') && s2 && (*s2 == '\0')) {         // Equals         return 0; etc. My environment is Arch Linux (Antergos flavor).
2019-08-13 09:39:24 Roy Wellington bug added subscriber Roy Wellington
2019-09-04 19:00:00 moma audio-recorder: status New Fix Committed
2019-09-04 19:00:04 moma audio-recorder: importance Undecided High
2019-09-04 19:00:06 moma audio-recorder: assignee moma (osmoma)