Display controls if the cursor is moved in fullscreen

Bug #912642 reported by Cody Garver
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Audience
Fix Released
Low
Pim Vullers

Bug Description

When watching a video in fullscreen, moving the cursor should make the controls appear. After 3 seconds of no action/cursor-movement, hide the controls.

Tags: bitesize
Cody Garver (codygarver)
tags: added: bitesize
Cody Garver (codygarver)
summary: - Display controls when the cursor is moved in fullscreen
+ Display controls if the cursor is moved in fullscreen
Changed in audience:
status: New → Confirmed
Pim Vullers (pimvullers)
Changed in audience:
assignee: nobody → Pim Vullers (pimvullers)
status: Confirmed → Won't Fix
status: Won't Fix → In Progress
Revision history for this message
Pim Vullers (pimvullers) wrote :

The linked branch implements show/hide of the controls on mouse move/3 seconds timeout. As far as I can see it works fine. The only point is that I recreate/add the timeout very often (every mouse move while controls visible) since I do not know a better way, but it does not seem to harm performance.

Let me know if it's ok, or if you prefer some changes. Otherwise you can pull it into trunk.

Changed in audience:
importance: Undecided → Low
Revision history for this message
Cody Garver (codygarver) wrote :

My only issue with this branch is that the timer does not disengage when leaving fullscreen which causes the controls to be hidden even though the window is not fullscreened. Can you fix this?

To recreate:

Play video then hit the F key to enter fullscreen > Move the mouse slightly to expose the controls and begin the timer > Hit F again to exit fullscreen (before controls autohide) > Observe that the timer continues then hides the controls when it expires

Revision history for this message
Pim Vullers (pimvullers) wrote :

Thanks for the heads up on this issue. I know how to fix this one. But I found a similar issue with the current on_click behavior (click to show, move mouse, controls will hide while not clicked again). Do we still want to maintain this on_click functionality or is the new behaviour favoured over the click one?

Revision history for this message
Cody Garver (codygarver) wrote :

It's safe to disable click to show controls. In the future, single clicking and holding the DrawingArea should make the window draggable. But that's a problem for another day.

Revision history for this message
Pim Vullers (pimvullers) wrote :

Fixed the issue you reported and dropped on_click. Please check one more time before merging into trunk...

Revision history for this message
Cody Garver (codygarver) wrote :

I have no complaints. Pim, once again you've single-handedly increased the maturity and usability of the Audience project with a great feature. Cheers for that for sure.

bzr branch lp:audience && cd audience && bzr merge lp:~pimvullers/+junk/audience-controls-on-mouse-move && bzr commit -m "Fix bug #912642 Display controls if the cursor is moved in fullscreen" && bzr push lp:audience

And "Fix committed".

Pim Vullers (pimvullers)
Changed in audience:
status: In Progress → Fix Committed
Cody Garver (codygarver)
Changed in audience:
milestone: none → 0.1
Changed in audience:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.