Black sidebars when playing any video format [$100]

[Belenos]

I'm experiencing this weird bug since beta1 release. Doesn't matter if I resize the window, the black bars persist.

[Julián Unrrein (junrrein)]

I think the problem is that the aspect ratio is being locked for resizing when first opening a video. Going full-screen and back seems to let the Audience window be normally resized again. Can you check this please?

[Belenos (belenos)]

Yes, but it isn't "locking" the window size when reaches de video limits.

[Julián Unrrein (junrrein)]

Thanks for the screencast, I understand it now.

[Viko Adi Rahmawan (vikoadi)]

I think the problem is because now we use headerbar and set_geometry_hints take headerbar height into account while trying to preserve window aspect ratio.
Am I right to consider adding VideoPlayer Widget as geometry_widget parameter in http://valadoc.org/#!api=gtk+-3.0/Gtk.Window.set_geometry_hints should do the trick but it dont? Isn't it a Gtk's bug?

[Artem Anufrij (artem-anufrij)]

redundant bug:
https://bugs.launchpad.net/audience/+bug/1356961

[Danielle Foré (danrabbit)]

https://www.bountysource.com/issues/4244275-black-sidebars-when-playing-any-video-format

[Tom Beckmann (tombeckmann)]

If definitely is the headerbars that add to the geometry that cause the problems here. The difficult part is to figure out how the CSD window will scale. My branch should get rid of the large black horizontal bars, but it will most probably add two small vertical ones. Still investigating.

[Felipe Escoto (philip.scott)]

Since the back bars don't show up after maximizing and restoring the window, couldn't we fix it by executing that code before making the window visible, or by maximizing and minimizing in a different workspace?

[Artem Anufrij (artem-anufrij)]

Some videos have a wrong ratio.

See screenshot:

[skmlcd (skmlcd)]

I had this issue for a long time, but after I updated today this does not happen anymore. Is this issue solved?

[Belenos (belenos)]

@skmlcd, I think so. But I still can see the black bars for a few milliseconds before the video start (and the window resizing).

[Tom Beckmann (tombeckmann)]

The client side decorations mess up aspect ratio locking quite badly, in order to keep it we had to resort to some workarounds. To be more precise, the approach that is has just been merged to trunk adjusts the window size to fit into the correct aspect ratio instead of relying on the window manager. In order to not break user-controlled window resizing while doing so, we have to use a small timeout before we apply the perfect window size since otherwise the window would jump around on your screen because resizing may either be amplified or nullified by the adjustment.

(A note on why that was necessary in case you're curious: previously the entire window area that belonged to the client was filled by the video, so we could just pass the video aspect ratio to the window manager and tell it to keep the window that way. The WM would then add its decorations on top of whatever geometry was correct. Now with CSD, we have a large area on top that is not video. The size of this area is constant, while the displayed video size varies when the window resized. The fact that we now have a varying and a constant value doesn't allow us to determine a linear value that can act as aspect ratio anymore, instead we now get different values depending on video size relative to decoration size.)