router does not subscribe to correct floatingip events

[Adam Gandelman]

Test:

- boot a nova instance /w a internal IP on a network plugged to a router
- manually associate floating ip via novaclient or horizon
- floating ip never gets brought up in the router, astara never pushes a new config

Cause:

We previously updated config on any *.end event.

Change https://review.openstack.org/#/c/291929/ modified this to avoid needlessly subscribing to all *.end events and instead subscribed explicitly to floating ip events. Floating ip assoc. does not cause a config update, however. Instead we drop the msg:

2016-04-29 15:19:29.450 DEBUG astara.notifications:2468:notification-listener:Thread-1 [-] Could not construct any events from floatingip.update.end /w payload: {u'floatingip': {u'router_id': u'6cf49580-1669-4654-a560-f1b38acf2ffc', u'status': u'DOWN', u'description': u'', u'dns_name': u'', u'dns_domain': u'', u'floating_network_id': u'68bcc5f7-c0ad-4d2e-b467-73522b94a4e9', u'fixed_ip_address': u'192.168.26.3', u'floating_ip_address': u'192.168.25.227', u'tenant_id': u'24c44dd65e784a58a3bc0f2a0a6ae814', u'port_id': u'38e37e7a-da6b-48bd-b85b-03eb0bcee53e', u'id': u'8eaf6fa2-eadb-4937-8219-52ba033c0896'}} from (pid=2468) info /opt/stack/astara/astara/notifications.py:149

I believe the correct event we need to look for is floatingip.update.end, not floatingip.change.end. I am unsure if the *.change.* event is valid for floating ips at all.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/311295

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/311300

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/311295
Committed: https://git.openstack.org/cgit/openstack/astara/commit/?id=3f26c9a298b126ed1ff01d1888399f3ed6810ae6
Submitter: Jenkins
Branch: master

commit 3f26c9a298b126ed1ff01d1888399f3ed6810ae6
Author: Adam Gandelman <email address hidden>
Date: Fri Apr 29 15:32:48 2016 -0700

    Subscribe to correct event for FIP assoc/disassoc

    Subscribe to the correct floatingip event for events that broadcast
    when a nova associate or disassociate floating IP takes place.

    Change-Id: I9aa0704fc7de75b22ecfb8795a65671e8ffcae23
    Closes-bug: #1576886

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/311300
Committed: https://git.openstack.org/cgit/openstack/astara/commit/?id=929fff40289fb0f7d8ecf878f439aa4a2482df72
Submitter: Jenkins
Branch: stable/mitaka

commit 929fff40289fb0f7d8ecf878f439aa4a2482df72
Author: Adam Gandelman <email address hidden>
Date: Fri Apr 29 15:32:48 2016 -0700

    Subscribe to correct event for FIP assoc/disassoc

    Subscribe to the correct floatingip event for events that broadcast
    when a nova associate or disassociate floating IP takes place.

    Change-Id: I9aa0704fc7de75b22ecfb8795a65671e8ffcae23
    Closes-bug: #1576886
    (cherry picked from commit 3f26c9a298b126ed1ff01d1888399f3ed6810ae6)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/astara 9.0.0.0b1 development milestone.