orchestrator.ini.sample should not bet tracked in git

Bug #1535889 reported by Adam Gandelman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Astara
Fix Released
Low
Adam Gandelman

Bug Description

Running 'tox -e genconfig' produces different output every time its run. it appears that the ordering of things in the config sample changes on every run, causing lots of confusing changes everytime its generated. Ideally, it should produce the same sample every time it is run (provided actual config options do not change) I've tried setting PYTHONHASHSEED=0 hoping that might help, but it doesn't.

test:
git clone https://github.com/openstack/astara
cd astara
tox -e genconfig
cp etc/orchestrator.ini.sample /tmp/1
tox -e genconfig
diff /tmp/1 etc/orchestrator.ini.sample

Changed in astara:
importance: Undecided → Medium
Revision history for this message
Adam Gandelman (gandelman-a) wrote :

OK so this isn't specific to astara. The thing that is specific, is that we're tracking the sample in git. We should probably drop it from git, ship an orchestrator.ini that gets updated at release time, and have devstack plugin generate config sample and use that as part of gating. some of this was originally proposed by xiayu and I -1d it, so apologies for that!

Changed in astara:
milestone: none → mitaka-2
status: New → Incomplete
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to astara (master)

Fix proposed to branch: master
Review: https://review.openstack.org/269864

xiayu (1013230155-v)
Changed in astara:
assignee: nobody → xiayu (1013230155-v)
assignee: xiayu (1013230155-v) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to astara (master)

Reviewed: https://review.openstack.org/269864
Committed: https://git.openstack.org/cgit/openstack/astara/commit/?id=c598f366eca4ad9da06e4e205e7c0ddbd0bf4ab0
Submitter: Jenkins
Branch: master

commit c598f366eca4ad9da06e4e205e7c0ddbd0bf4ab0
Author: Adam Gandelman <email address hidden>
Date: Tue Jan 19 13:20:14 2016 -0800

    Drop orchestrator.ini.sample from git

    This drops tracking of the generated sample from git, since the output
    of generation is non-deterministic, we end up with big changes to this
    file anytime someone proposes a change that requires a new sample.

    Instead, lets track orchestrator.ini and update it at milestone/release
    times.

    Also, have the devstack plugin generate and use a sample, that way we
    get some gate testing on proposed config changes.

    Change-Id: Iaf5127733765e973dbf0e812f267a3304c575fd4
    Closes-bug: #1535889

Changed in astara:
status: In Progress → Fix Released
summary: - config sample generation is non-deterministic
+ orchestrator.ini.sample should not bet racked in git
summary: - orchestrator.ini.sample should not bet racked in git
+ orchestrator.ini.sample should not bet tracked in git
Changed in astara:
assignee: nobody → Adam Gandelman (gandelman-a)
importance: Medium → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.