test-encodings fails on ECL on (k)ubuntu

Bug #1596551 reported by Robert P. Goldman on 2016-06-27
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ASDF
Undecided
Robert P. Goldman

Bug Description

Here's the backtrace:

Test TEST-ENCODING-IMPLICIT-AUTODETECT: should be LATIN-2
; Registering #<system "test-encoding-implicit-autodetect">
TEST ABORTED: unsupported encoding :LATIN-2
0: (#:G2328 NIL)
1: (UIOP/STREAM:CALL-WITH-SAFE-IO-SYNTAX #(140731336751552 140135009993280 140731336751448))
2: (UIOP/IMAGE:PRINT-BACKTRACE NIL)
3: (UIOP/IMAGE:PRINT-CONDITION-BACKTRACE #(1 140135009997344 140731336752504))
4: (#<bytecompiled-function ASDF-TEST:ACALL> ((ASDF-TEST::ARGS #<a SIMPLE-ERROR> :COUNT 69 :STREAM #<output file "stdout">) (ASDF-TEST::NAME . :PRINT-CONDITION-BACKTRACE)))
5: (#<bytecompiled-function 00000000027901e0> ((7378 . 0) (#:G236) (7377 . #:G235) (ASDF-TEST::C . #<a SIMPLE-ERROR>) (:ASDF-TEST-DONE . :ASDF-TEST-DONE) (ASDF-TEST::THUNK . #<bytecompiled-closure #<bytecompiled-function 00000000048d7aa0>>)))
6: (ASDF-ENCODINGS:ENCODING-EXTERNAL-FORMAT #(1 140134999993632 140731336755640))
7: (UIOP/STREAM:ENCODING-EXTERNAL-FORMAT #(1 140135009993120 140731336756088))
8: (#:G3255 #(1 140135010018608 140731336756280))
9: (#:G4139 NIL)
10: (UIOP/UTILITY:CALL-FUNCTION #(1 140135009986576 140731336758232))
11: (UIOP/LISP-BUILD:CALL-AROUND-HOOK #(1 140135010002912 140731336758648 140731336758640))
12: (#:G4039 #(1 140135010022016 140731336758856 140731336758848))
13: (ASDF/LISP-ACTION:PERFORM-LISP-LOAD-SOURCE NIL)
14: (#:G4140 #(1 140135010022688 140731336760136 140731336760128))
15: (#:G3996 #(1 140135010021792 140731336761368 140731336761360))
16: (#:G4021 NIL)
17: (#:G4696 #(140731336763312 140135010025152 140731336763192 140731336763184 140731336763176))
18: (#:G4688 #(140731336764432 140135010025024 140731336764376 140731336764368))
19: (#:G4691 #(1 140135010025072 140731336765832))
20: (#:G4688 #(140731336766736 140135010025024 140731336766680 140731336766672))
21: (#:G4898 #(140731336768224 140135010026592 140731336768168))
22: (CALL-NEXT-METHOD NIL)
23: (#:G4881 NIL)
24: (ASDF/CACHE:CALL-WITH-ASDF-CACHE #(1 140135010005984 140731336769840))
25: (#:G4874 #(140731336770432 140135010026400 140731336770376 140731336770360 140731336770352))
26: (#:G4868 #(1 140135010026304 140731336771880 140731336771872))
27: (CALL-NEXT-METHOD NIL)
28: (#:G4881 NIL)
29: (ASDF/CACHE:CALL-WITH-ASDF-CACHE #(1 140135010005984 140731336773488))
30: (#:G4874 #(140731336774080 140135010026400 140731336774024 140731336774008 140731336774000))
31: (#:G4874 #(140731336775648 140135010026400 140731336775592 140731336775576 140731336775568))
32: (#<bytecompiled-function 0000000005462190> NIL)
33: (ASDF/CACHE:CALL-WITH-ASDF-CACHE #(1 140135010005984 140731336777600))
34: (#<bytecompiled-function 0000000005462140> NIL)
35: (#<bytecompiled-function ASDF-TEST::CALL-WITH-EXPECTED-FAILURE> ((ASDF-TEST::THUNK . #<bytecompiled-function 0000000005462140>) (CONDITION)))
36: (#<bytecompiled-function SI:BYTECODES> NIL)
37: (#<bytecompiled-function 00000000048d7aa0> ((ASDF-TEST::NAME . "test-encodings.script") (ASDF-TEST::FILE . ASDF-TEST::|test-encodings.script|)))
38: (ASDF/CACHE:CALL-WITH-ASDF-CACHE #(1 140135010005984 140731336781072))
39: (#<bytecompiled-function ASDF-TEST::CALL-WITH-TEST> ((:ASDF-TEST-DONE . :ASDF-TEST-DONE) (ASDF-TEST::THUNK . #<bytecompiled-closure #<bytecompiled-function 00000000048d7aa0>>)))
40: (#<bytecompiled-function ASDF-TEST:RUN-TEST-SCRIPT> ((ASDF-TEST::FILE . ASDF-TEST::|test-encodings.script|)))
41: (#<bytecompiled-function SI:BYTECODES> NIL)
42: (#<bytecompiled-function SI:BYTECODES> ((SI::OUTPUT-FILE . T) (SI::C-FILE) (SI::H-FILE) (SI::DATA-FILE) (SI::VERBOSE . T) (SI::SYSTEM-P) (EXT:QUIT)))
43: (#<bytecompiled-function SI:BYTECODES> NIL)
44: (NIL NIL)
Above backtrace due to this condition:
unsupported encoding :LATIN-2
Script failed
Using ecl, test-encodings.script failed

The same failure on ecl_bytecodes

This is ECL 15.3.7 installed via the Ubuntu package.

Robert P. Goldman (rpgoldman) wrote :

Reviewing test-encodings.script, I see immediately BELOW the test that fails this line:

#+ecl
(leave-test "ECL recently broke its encoding support" 0)

So should that be *above* the failing test, instead of below it?

On my Mac, the test "passes", but only because it can't find asdf-encodings. Hm. Not sure why it can't. *another* problem.

Robert P. Goldman (rpgoldman) wrote :

OK, I found out why: the initialization to load ASDF-ENCODINGS in test-encodings.script was wrong. I don't think it would EVER have loaded that system. I have committed a patch for that and am retesting.

Robert P. Goldman (rpgoldman) wrote :

This seems to have been more a set of bugs in test-encodings.script than in ASDF or ECL.

I fixed the conditions for testing, so that we only test on recent ECLs that we expect will work, and in fact, it does.

Closing this as fix committed.

Changed in asdf:
assignee: nobody → Robert P. Goldman (rpgoldman)
status: New → Fix Committed
Daniel Kochmański (jackdaniel) wrote :

So ECL works just OK wrt encoding and latin-2?

Robert P. Goldman (rpgoldman) wrote :

My copy of ECL 16.0.0 passes these testa, as far as I can tell.

I disabled testing for older-than-16 versions of ECL.

I suppose it might be better to raise some sort of condition if you try to use ASDF-ENCODINGS on older-than-16 versions of ECL. But I guess I'm not even sure why I'm testing ASDF-ENCODINGS, since it isn't part of ASDF proper...

Faré (fahree) wrote :

We're testing the encoding hooks of ASDF, which are only stress-tested by ASDF-ENCODINGS.

Maybe we could argue that UTF-8 has won, and that this hook can be removed. Or not.

Changed in asdf:
status: Fix Committed → Fix Released
milestone: none → 3.3
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers