Ladder Duplicates with Authentication

[Yann Kaiser]

http://forums.armagetronad.net/viewtopic.php?p=198080#198080

Quoting Alpha Centauri:

After adding Armathentication to the servers I admin, I've noticed that we have entries being duplicated in the ladder. Not like unauthenticated users and authenticated users having the same name, but actual duplicates. Here are a couple excerpts:

5.29999 N9\:\:Alpha@
4.95724 c$\<email address hidden>
2.11496 c$\<email address hidden>
1.07578 n9\:\:alpha@

It's also interesting to note that the former "N9::Alpha" entry is the only one with capital letters in the whole ladder. Any ideas?

It appears the same thing is happening with the won rounds/matches files too.

[Yann Kaiser (epsy)]

yep, just found some faulty lines along something like this:
                    gStats->highscores->greater(se_PlayerNetIDs(0)->GetName(), se_PlayerNetIDs(0)->Score());

..while it's GetUserName() that should be called

[Manuel Moos (z-man)]

Right. Major misunderstanding. Upon reading epsy's analysis, I looked at the code and saw no calls to ePlayerNetID::GetName() any more, and assumed it was fixed. Only that
a) epsy's code was from trunk, I was looking at 0.2.8
b) it wasn't the problem after all. The problem came from the highsocre loading function applying standard name filtering. That is now fixed.
Trunk probably doesn't even have this bug. But the statistics there don't look like they'd use authentication names, they're always using screen names. A job for Tank.