Players can rename mid-round
Bug #394108 reported by
dlh
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Armagetron Advanced |
Fix Committed
|
Medium
|
Unassigned | ||
| 0.2.8 |
Fix Committed
|
Medium
|
Manuel Moos | ||
Bug Description
To reproduce:
1. Log in using auth.
2. Change your PLAYER_1 name.
3. /logout
Result: name has changed to your new PLAYER_1.
The server should control when a player is allowed to rename. I think we should still allow auth logins at anytime, but /logout's should be processed like regular name changes.
Related branches
Revision history for this message
| Manuel Moos (z-man) wrote | #1 |
| Changed in armagetronad: | |
| importance: | Undecided → Medium |
| milestone: | none → 0.2.8.3 |
| status: | New → Fix Committed |
Revision history for this message
| Yann Kaiser (epsy) wrote | #2 |
To post a comment you must log in.
We do control player name changes. The problem was just that we allow a player update on login/logout; the reason for that, as far as I recall, was that if you play with a reserved nickname, you'd only be allowed to take it after you authenticate; there's a delay between entering the server and authenticating properly, but you'd want to be renamed from 'fake free kill' to 'free kill' ASAP. Well, I removed those updates, hoping there was no other, more important reason. Nobody is reserving nicknames anyway.