Players can rename mid-round

Bug #394108 reported by dlh on 2009-07-01
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Armagetron Advanced
Manuel Moos

Bug Description

To reproduce:

1. Log in using auth.
2. Change your PLAYER_1 name.
3. /logout

Result: name has changed to your new PLAYER_1.

The server should control when a player is allowed to rename. I think we should still allow auth logins at anytime, but /logout's should be processed like regular name changes.

Related branches

Manuel Moos (z-man) wrote :

We do control player name changes. The problem was just that we allow a player update on login/logout; the reason for that, as far as I recall, was that if you play with a reserved nickname, you'd only be allowed to take it after you authenticate; there's a delay between entering the server and authenticating properly, but you'd want to be renamed from 'fake free kill' to 'free kill' ASAP. Well, I removed those updates, hoping there was no other, more important reason. Nobody is reserving nicknames anyway.

Changed in armagetronad:
importance: Undecided → Medium
milestone: none →
status: New → Fix Committed
Yann Kaiser (epsy) wrote :

AFAIK it was done for fixing bug 223625. Maybe only recomputing the username as soon as the user is logged out/in would be better.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers