height=0 not respected on walls

Bug #345213 reported by Luke-Jr
2
Affects Status Importance Assigned to Milestone
Armagetron Advanced
Confirmed
Wishlist
Luke-Jr

Bug Description

A wall with a 0 height should be invisible. Instead 0 seems to take on a "default height" meaning.

Revision history for this message
Manuel Moos (z-man) wrote :

This was by design :) Apparently, the designer did not think about the benefit of having a default value applied iff height= is omitted. Feel free to fix, but mind backwards compatibility with maps using old dtds that rely on this.

Changed in armagetronad:
assignee: nobody → luke-jr
status: New → Confirmed
Revision history for this message
Luke-Jr (luke-jr) wrote :

What old DTDs are you referring to? I can't find any that default to 0.

Revision history for this message
Manuel Moos (z-man) wrote :

Old == all current. Yeah, they don't define a default. However, it's possible that a map designer using those dts would have put height="0" in there to get a default height wall, and that behavior shouldn't be changed. However, It's more likely he'd just have left the height out; the 0 value is then implicitly added by the float getting code in the parser. Dunno. Just grep the resource repository to see whether height="0" is actively used or not. If it's not used too much, don't bother with adding legacy code.

Changed in armagetronad:
importance: Undecided → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.