trunk can't connect to 0.2.8.2.1 servers

Bug #331940 reported by BabyBug
2
Affects Status Importance Assigned to Milestone
Armagetron Advanced
Status tracked in Trunk
Trunk
Fix Committed
High
Manuel Moos

Bug Description

Trunk can't connect to any 0.2.8.2.1 servers, but does connect to more recent servers..

Revision history for this message
Yann Kaiser (epsy) wrote :

It sounds like it is getting a wrong address. (Haven't checked, though.) Does not happen before protobuf inclusion.

Changed in armagetronad:
importance: Undecided → High
milestone: none → 0.3.1
status: New → Confirmed
Revision history for this message
Manuel Moos (z-man) wrote :

The address was just a symptom :) The real cause was the login token which was added wrongly by the same code. The login token is used thusly:

the client randomly generates it and sends it to the server on login

the server, if > 0.2.8_somealpha, copies it over to the login accept message

if present in the login accept, the client compares it to the token it sent

Now, if the server doesn't reply with the token, but some code on the client adds it, the comparison fails and the client won't accept the login accept packet.

Anyway, the code adding default valued fields to received messages has been fixed, it would have caused no end of trouble in other areas as well.

Changed in armagetronad:
assignee: nobody → z-man
milestone: 0.3.1 → 0.3.2
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.