pthreads not working/not used

Bug #272398 reported by Yann Kaiser on 2008-09-20
4
Affects Status Importance Assigned to Milestone
Armagetron Advanced
Medium
Luke-Jr

Bug Description

luke introduced recently pthreads support, but forgot to put hooks in the most important parts
I wrote a patch to that purpose, but it crashes at second auth try

putting that here so we have a better place to either
* fix the patch
* ditch pthreads

(zthread support is still present atm, but at configure time, pthread gets 'priority')

Yann Kaiser (epsy) wrote :
Changed in armagetronad:
importance: Undecided → Critical
milestone: none → 0.2.8.3
Luke-Jr (luke-jr) wrote :

For reference, I did this for several reasons:
- zThread is no longer maintained
- zThread is not available for any Debian
- pthreads is standard/built-in to any common OS

Yann Kaiser (epsy) wrote :

Removed from 0.2.8, here is the original patch.

Luke-Jr (luke-jr) wrote :

If you're going to disable it, please do so correctly: modify the configure script to never enable it, don't remove the code entirely...

Yann Kaiser (epsy) on 2008-10-18
Changed in armagetronad:
importance: Critical → Medium
Luke-Jr (luke-jr) wrote :

Please test 0.2.8 HEAD; it should work now (also re-enabled)...

Luke-Jr (luke-jr) wrote :

Note that my machines are all still single-core, so REAL testing is much needed. :)

Changed in armagetronad:
assignee: nobody → luke-jr
status: New → Fix Committed
carlo veneziano (hoop) wrote :

server crashes randomly when I try to login:
armagetronad-dedicated: tpp.c:63: __pthread_tpp_change_priority: Assertion `new_prio == -1 || (new_prio >= __sched_fifo_min_prio && new_prio <= __sched_fifo_max_prio)' failed.

carlo veneziano (hoop) wrote :

client recording:
- Login attempt denied because server was recording too: "Your login process will be delayed [...]"
- Left the server
- Joined again: the request was still pending (is that behavior wanted??) -> inserted password
- When round finished the login didn't succeed
- Tried again to login, died, inserted password
- At round end server crashed

sorry for the (short) time you'll lose watching me playing, I couldn't resist XD

carlo veneziano (hoop) wrote :

server recording, same session as the above attachment
(zipped this time ;P)

Luke-Jr (luke-jr) wrote :

Fixed in revision 8599

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints