Segfault in nDescriptor::HandleMessage from using the multiplayer menu in game

Bug #1837707 reported by SwagTron
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Armagetron Advanced
Fix Committed
Manuel Moos

Bug Description

While attempting to make an in-game browser, I enabled the online multiplayer menu in the main menu. When connecting to another server by using the bookmark menu or the custom connect menu, the server segfaults

Nelg generated the backtrace from a sty-ct-ap server.
#0 0x0000000000000000 in ?? ()
#1 0x00005555555fbcf7 in tControlledPTR<nNetObject>::AddRef (
    this=0x7fffffffd938) at ./tools/tSafePTR.h:176
#2 0x00005555555f9693 in tControlledPTR<nNetObject>::tControlledPTR (
    this=0x7fffffffd938, x=0x555556049ef0) at ./tools/tSafePTR.h:194
#3 0x000055555574e2c9 in nNetObject::ClearKnows (user=2, clear=true)
    at network/nNetObject.cpp:1815
#4 0x000055555574e31a in ClearKnows (user=2, clear=true)
    at network/nNetObject.cpp:1825
#5 0x000055555574e649 in login_callback () at network/nNetObject.cpp:1893
#6 0x000055555579e555 in tCallback::Exec (anchor=0x555555ace520 <_ZL3nlc>)
    at tools/tCallback.cpp:38
#7 0x000055555579e569 in tCallback::Exec (anchor=0x555555ae4300 <_ZL3nlc>)
    at tools/tCallback.cpp:39
#8 0x0000555555761a63 in nCallbackLoginLogout::UserLoggedOut (u=2)
    at network/nNetwork.cpp:3854
#9 0x00005555557616ba in sn_DisconnectUserNoWarn (i=2, reason=..., redirectTo=
    0x0) at network/nNetwork.cpp:3803
#10 0x00005555557613cc in sn_DisconnectUser (i=2, reason=..., redirectTo=0x0)
    at network/nNetwork.cpp:3739
#11 0x000055555575ba27 in logout_handler (m=...) at network/nNetwork.cpp:2188
#12 0x000055555575707d in nDescriptor::HandleMessage (message=...)
    at network/nNetwork.cpp:618

I added the ret_to_MainMenu() function to my in-game browser to stop the crashing, but still thought I'd report the issue. This crashes all branches 2.8 - 0.4.

SwagTron (swag)
description: updated
SwagTron (swag)
information type: Public → Private Security
information type: Private Security → Public
information type: Public → Private Security
SwagTron (swag)
information type: Private Security → Public Security
Manuel Moos (z-man)
Changed in armagetronad:
importance: Undecided → Critical
status: New → Fix Committed
Revision history for this message
Manuel Moos (z-man) wrote :

Huh, apparently I fixed this around Revision 1520
(Git hash 387da061770148388290dbd8051c0179c23221f2) in the days after this report.

Changed in armagetronad:
assignee: nobody → Manuel Moos (z-man)
To post a comment you must log in.
This report contains Public Security information  
Everyone can see this security related information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.