IFV + Temporal weapon + mobile fire

Somehow I feel that the more code we add, the crazier unexpected side-effects will be.

Thanks for reporting, especially in this amount of detail. :)

Disabling 71A87B, TemporalClass_Update_CacheWH, 6 makes this work, however disabling this and keeping the Warpaway hook will break Temporal totally.

Still, the WarpAway deglobalization causes this.

I can confirm that I noticed this a long time ago, never figured out that cause though (and therefore didn't think it was an Ares issue)... good to know.

A change related to this bug has been committed:

https://github.com/Ares-Developers/Ares/commit/b1fdb691f3dfa1a5f9dbc0cba84c906fdc2fc7a6

Potential fix for issue 1517/bug 896130 (Temporal + Fire on the Move) :

Funny westwood/Ares logic interaction was happening previously.
Stock YR code creates a TemporalImUsing only for TechnoClass whose *Primary* is Temporal, not secondary or other. This means you couldn't have temporal secondaries. Ares fixed that by instantiating it for every unit that needs it.
This unfortunately was done without properly investigating the IFV weapon switching code. This code replaces the vehicle's TemporalImUsing with the gunner's when it enters, and hands it back to the gunner when s/he exits the vehicle. After this, the unit's TIU is set to NULL. This means that 1) the unit's original TIU that Ares instantiated is leaked; 2) if the unit did have a Temporal weapon for its unmanned mode, it will crash when trying to fire it.
In addition, this had an unexpected side-effect. UnitClass::GetFireError is called to check if a unit can fire at the moment, and that code says 'you cannot fire, you are moving' if a unit has a TemporalImUsing and is moving. This means that in Ares, an IFV cannot use MobileFire=yes (if it does, it will only be able to fire on the move correctly *after* a temporal-wielding gunner exits it).
This commit should theoretically fix these problems:
- Save the unit's original TIU before a gunner replaces it
- Restore it after a gunner exits
- just for completeness, sweep the saved pointer when running AnnounceInvalidPointer, even though it shouldn't come to this.
- Change to 'you cannot fire, you are moving' to check if the unit is a gunner and currently wielding a temporal weapon OR not a gunner and in possession of a TIU. This condition *should* be correct...

I wonder if this fix works for anyone...

I thought I already told you on IRC on that same day or the following one that the fix worked here.

Why do we tell people to file bugs instead of reporting them on IRC? So that we don't have to keep random IRC convos in our heads and tell all the other developers about a bug J Random User reported...

Same here, if I was on IRC when you reported that, doesn't mean Ren or Alex were, and what should they do if they want to know the status? Also, it's really our standard procedure to ask for multiple confirmations, you know :)

It's fixed.

Confirmed as fixed by Speeder and mevitar.