Issue with hotkeys strings

[Chanterier]

The following issue happens when I have my stringtable00.csf in the game's directory.

http://i53.tinypic.com/8xmxkn.png

Several strings for hotkeys are reported as MISSING (in 'Commands' and 'Description' windows). My stringtable00.csf does not alter any of CMND strings nor does it add new ones into that category.

Restating "missing" strings in stringtable00.csf does not fix the problem. Of course, those strings are available in the original ra2md.csf file.

The following strings are reported as MISSING:

CMND:CombatantSelect
CMND:Delete
CMND:DeleteDesc
CMND:HealthNavigation
CMND:PlanningMode
CMND:PlanningModeDesc
CMND:TypeSelect
CMND:VetNavigation

[DCoder DCoder (dcoder1337)]

The fix for this is https://github.com/Ares-Developers/Ares/commit/1c4762d029a3bdfc783a9b56ae58373348e92f97 .

Technical details: pointer math works differently in ASM and C/C++.
In ASM, there is nothing special about pointers, subtracting two memory addresses yields the difference in bytes.
In C/C++, only pointers of the same type can be subtracted from each other, and the result is the number of objects of that type that would fit between lhs (inclusive) and rhs (exclusive).
The code was returning a correct asm-ish difference in one case and a C-ish difference in the other case, which was incorrect and resulted in memory corruption.

[DCoder DCoder (dcoder1337)]

TODO in the future: rewrite the whole fuckdamned CSF handling logic to use a hashmap or something less magicky, and incorporate the missing/nostr handling into it as well.

[OmegaBolt (omegabolt)]

I can confirm this is fixed.

[Renegade (renegade)]

Thanks, Omega.