Customizable user interface colors

Bug #896007 reported by AlexB
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ares
Fix Released
Wishlist
AlexB

Bug Description

Add tags for customizing the colors used in the user interface.

Revision history for this message
Bug Importer (bug-importer) wrote :

Code related to this issue has just been checked in!
Author: AlexB
Location: ft-menucolors, r950
Commit contains DLL: Yes
Revision comment:
Fixed issue #1395: Several new uimd.ini tags added to customize colors.
Fixed issue #224: Color.Text allows changing text color.
Fixed issue #197: Dropdown colors are customizable. Up to 16 colors can be displayed. Added six new color schemes for demonstration purposes.

Small known bug: If there are more than 8 items in the dropdown list, the random color item "???" is abbreviated "..." when the list is dropped down.

The manual still needs some work. Css should be in the css file.
SVN: http://svn.renegadeprojects.com/Ares/950

Revision history for this message
Chanterier (speederyr) wrote :
Revision history for this message
YR M0ddEr (yr-m0dder) wrote :

So many tags, it wasnt fun to test.
Here is results:

Almost all tags worked
Color.Groupbox.Text=206,255,206 ;Cant see this color anywere(Light green)
Color.Disabled=255,255,255;Dosent play the color I write, tired other colors too..
Color.X.Disabled= this was wierd, probably becuse Color.Disabled= dont work(I am aware that X is replaced)

Revision history for this message
Rogan (pdrogan) wrote :

Here are the results:
Color.Border1=0,0,0 ;Working
Color.Border2=0,100,100 ;Working
Color.Text=255,255,255 ;Working
Color.Selection=0,255,255 ;Working
Color.Disabled=125,125,125 ;Working
Color.ObserverOpen=125,0,125 ;Working
Color.ObserverSide=10,10,10 ;Working

I need some time to test the individual tags for text, selection, and disabled however...

Also, this release branch seems to have broken the campaign selection menu:
I get an IE when the select the Campaigns button in the Single player menu.
It used to work fine in the trunk.

Revision history for this message
YR M0ddEr (yr-m0dder) wrote :

Drogan is right, campaign selection menu results in IE.

Revision history for this message
AlexB (alexander-b) wrote :

Color.Groupbox.Text=206,255,206 ;Cant see this color anywere(Light green)
How do the network options look like?

Color.Disabled=, Color.X.Disabled=
Working or not?

Regarding the campaign menu:
This looks like a bug that wasn't caught in the Third Button branch. Please always post what settings you used so I don't have to find out it is only crashing with CampaignList=yes.

Revision history for this message
Bug Importer (bug-importer) wrote :

Code related to this issue has just been checked in!
Author: AlexB
Location: ft-menucolors, r953
Commit contains DLL: Yes
Revision comment:
Related to issue #224: Manual updated.
Related to issue #1395: Crash related to Third Button and its CampaignList=yes setting resolved.
SVN: http://svn.renegadeprojects.com/Ares/953

Revision history for this message
Rogan (pdrogan) wrote :

The Campaign selection menu doesn't crash anymore!

I've carefully retested the tags, Including the individual tags:

Color.Border1=0,0,0 ;Working
Color.Border2=0,100,100 ;Working
Color.Text=0,0,255 ;Working
; Everything below is working
Color.Button.Text=220,0,0 ;red
Color.Label.Text=0,220,0 ;green
Color.Checkbox.Text=0,0,220 ;blue
Color.Combobox.Text=220,220,0 ;gold
Color.Groupbox.Text=220,0,220 ;magenta
Color.Slider.Text=0,220,220 ;light blue
Color.Edit.Text=220,220,220 ;bright grey
; -----------------------
Color.Selection=0,255,255 ;Working
Color.List.Selection=125,0,0 ;red ;This showed up purple (detailed below)
Color.Combobox.Selection= 255,255,255 ;white ;Correction:this doesn't work properly too.(detailed below)
; -----------------------
Color.Disabled=0,255,0 ;pure green ;Only shows default color (167,0,0) for Color.Button.disabled if left undefined. (It's working)
; Everything below is working
;;These are darkened versions of above.
Color.Button.Disabled=1,0,255
Color.Label.Disabled=0,120,0
Color.Checkbox.Disabled=0,0,120
Color.Combobox.Disabled=120,120,0
Color.Slider.Disabled=0,120,120
; -----------------------
Color.ObserverOpen=125,0,125 ;Working
Color.ObserverSide=10,10,10 ;Working
; -----------------------

So far, only the Color.X.Selection tag is the problem here.

EDIT: It seems that something is adding 0,0,255(?) to Color.X.Selection's RGB value, making any value either purple-ish, light blue-ish, white-ish or pure blue.

Revision history for this message
Graion Dilach (graiondilach) wrote :

Confirming Color.List.Selection. 0,0,0 value resulted with a 0,0,64 color.

Revision history for this message
Graion Dilach (graiondilach) wrote :

The game doesn't really select from the additional colors if random was selected (using 16 colors and 5 tries on 8 players, all random, computer selected additional color only once).

Revision history for this message
YR M0ddEr (yr-m0dder) wrote :

[i]Color.Groupbox.Text=220,0,220 ;magenta[/i]
Where did you find this?

----

Revision history for this message
AlexB (alexander-b) wrote :

Groupboxes ("frames" for the VB fans) are found on the Key Setup menu page "Description" and two of them are on the Network Options menu page.

Revision history for this message
YR M0ddEr (yr-m0dder) wrote :

From manual:
[UISettings]►Color.Disabled= (R,G,B)
The default color texts of disabled controls are drawn in. This does not affect the color of disabled buttons, see below. Defaults to 159,0,0 (dark red).

So what is a disabled control?

EDIT: ok I can see Color.Groupbox.Text= now

Revision history for this message
AlexB (alexander-b) wrote :

A disabled control is a thing you can't interact with because it is deactivated. Like the Load Savegame button if there are no save games or almost all controls in a network game dialog if you're not the host.

Revision history for this message
YR M0ddEr (yr-m0dder) wrote :

Ok, tested:
[UISettings]
Color.Disabled=255,0,255;Working
Color.Button.Disabled=255,0,255;Working
Color.Label.Disabled=255,0,255;Working
Color.List.Disabled=255,0,255;Working
Color.Checkbox.Disabled=255,0,255;Working
Color.Combobox.Disabled=255,0,255;Working
Color.Slider.Disabled=255,0,255;Working

Now, I have tested all these tags and every one of them is working.
Time to close eh?

Revision history for this message
AlexB (alexander-b) wrote :

Only if we want to ignore the bugs Drogan and Graion Dilach found.
The random color selection hasn't been touched yet, thus it only generates values for the first eight colors. I could recreate the selection color effect. If Color.Selection is set to black it should work, but of course this will be fixed.

Revision history for this message
Bug Importer (bug-importer) wrote :

Code related to this issue has just been checked in!
Author: AlexB
Location: ft-menucolors, r960
Commit contains DLL: Yes
Revision comment:
Fixed issue #1395: New colors are considered if random colors are selected. Color.X.Selected should work properly now. Both tags Color.ObserverOpen and Color.ObserverSide have been renamed to Color.Observer.Text and Color.Observer.Disabled respectively. A new tag, Color.Observer.Selected, has been added.

The manual has been updated, but it still needs some work.
SVN: http://svn.renegadeprojects.com/Ares/960

Revision history for this message
YR M0ddEr (yr-m0dder) wrote :

AlexB Wrote:
"Color.X.Selected= should work properly now"

I think you mean Color.X.Selection=(to avoid confusion)

---------

Retested in r960

New colors are selected in random.

Color.List.Selection= and Color.Combobox.Selection= works fine.

About observe, not sure about this
Color.Observer.Text=255,0,255;Pink
Color.Observer.Disabled=0,255,0;Green
Color.Observer.Selected=0,0,255;Blue

Observe is open, but empty:
http://img232.imageshack.us/img232/462/img1bb.png

Observe is open, and someone have joined the observe slot:
http://img407.imageshack.us/img407/5990/img2j.png

Selecting a observe slot:
http://img684.imageshack.us/img684/4155/img4ixu.png

Observe is closed:
http://img547.imageshack.us/img547/5139/img3u.png

Revision history for this message
AlexB (alexander-b) wrote :

Yeah, sorry, it's indeed Color.Observer.Selection. Everything's looking good, except for the Color.Observer.Selected=0,0,255;Blue, which should be "Selection" (then the dark grey selection background should be blue.

Revision history for this message
YR M0ddEr (yr-m0dder) wrote :

okey, I guess we should expect an update then

Note about Color.x.Selection=, I tried many different colors and they all worked fine(Graion Dilach said that 0,0,0 value resulted with a 0,0,64 color, this is now fixed)

Revision history for this message
Rogan (pdrogan) wrote :

All individual selection colors now shows its color properly and all of the observer color tags are working properly too.

I can also confirm that custom colors are now considered for the random color selection.

Revision history for this message
AlexB (alexander-b) wrote :

Thanks for testing! Closed.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.