Neutral Battle Bunkers do not switch houses when raided

[Professor_Tesla]

n/t

##### STEPS TO REPRODUCE #####
1. Raid a raidable Battle Bunker belonging to neutral.
2. Watch as the "raided" battle bunker starts attacking your units.

[Professor_Tesla (professor-tesla)]

Upon further testing, I have found that it works properly if the bunker is owned by another player (AI or human). The bug only happens if the bunker is owned by Neutral.

[DCoder DCoder (dcoder1337)]

"No longer" - did it use to work and suddenly stopped? If so, can you maybe narrow down the revision where it broke?

[Renegade (renegade)]

Thanks for the clarification comment. I'll look into it, but as D said, it'd help to get a rough idea of when it broke.

EDIT: After thinking about this further, I need more information about what's going on in the first place. Neutral occupiable buildings should be occupied like any other UC building; where do the neutral Battle Bunkers come from, and does this happen with UC buildings as well?

[Professor_Tesla (professor-tesla)]

Normal UC buildings work properly. It's only Neutral Battle Bunkers that don't.
EDIT: The Neutral Battle Bunker is on a map I'm using to test various features.
EDIT2: I wrote "no longer" because I thought that part of the feature was broken (the house-changing part) but that was before I did another test.

[Renegade (renegade)]

I'll need more information on this, especially how the Battle Bunker is set up (actual owning House + Side, INI stuff, etc.); mainly, the question to answer is whether the game treats the Battle Bunker just like normal, neutral urban combat buildings, or if it treats it like any other Battle Bunker, with the only difference being that it's owned by the Neutral country, instead of, say, Russia.

If the former, this is a regression in the UC/occupation code.
If the latter, this is a very special case of raiding that we can't really handle - we can't, on one hand, tell it to exclude Neutral from raiding for UC purposes, and, on the other hand, tell it to include Neutral to handle occupiable neutral weapons platforms.

EDIT: Also, I'll need info on whether this affects all occupiable, usually player-owned buildings, or just Battle Bunkers specifically.
For testing purposes, try altering a stock UC building to be buildable by a side and then see how it behaves pre-placed neutral on a map.

[Professor_Tesla (professor-tesla)]

I just tested this, and it seems that it's the TechLevel that causes this problem. I made The Alamo buildable and raidable, then pre-placed it on my test map (which already has a Battle Bunker pre-placed on it). I got the same problem with it as with the Battle Bunker. Then I changed both The Alamo's TechLevel and the Battle Bunker's TechLevel to -1, and they behaved like normal UC buildings.

[Bug Importer (bug-importer)]

Code related to this issue has just been checked in!
Author: Renegade
Location: trunk, r879
Commit contains DLL: No
Revision comment:
Slight changes to raiding code to account for the possibility of non-UC occupiable neutral buildings.
Related to issue #665 and fixing issue #1305.
SVN: http://svn.renegadeprojects.com/Ares/879

[Bug Importer (bug-importer)]

Code related to this issue has just been checked in!
Author: AlexB
Location: trunk, r880
Commit contains DLL: Yes
Revision comment:
New trunk binary.
Related to issue #665 and issue #1305.
SVN: http://svn.renegadeprojects.com/Ares/880

[Professor_Tesla (professor-tesla)]

I just tested this, and it is definitely fixed in the latest revision (Ares 0.1.880).

[Renegade (renegade)]

I'm very glad to hear that. :) Could you test if there are any regressions, i.e. could you check if raiding other/normal buildings still works as expected, and if urban combat does as well?

And could I get an independent confirmation on this?

[Professor_Tesla (professor-tesla)]

Yes, normal UC buildings still work properly. Also, raiding player (computer or human) owned buildings works properly if that's what you mean.

[Chanterier (speederyr)]

I haven't been following this issue much so sorry if this has been explained somewhere, but: when I capture a certain neutral-owned Battle Bunker I receive EVA report "Building captured" and then "Structure garrisoned". When I leave that bunker, it turns back to neutral house as it should be but the next time report "Building captured" is no longer played. Should it work this way? Should there be "Building captured" report the first time a bunker is raided?

[YR M0ddEr (yr-m0dder)]

Tested in 0.1.880

Works perfect.

This can be closed.

[Renegade (renegade)]

Closed as per comment above.