Ivan bombs vanishing on deploy

[mevitar]

Crazy Ivan's bombs have a habit of vanishing when placed on a unit that deploys into a building (and buildings undeploying into units). This doesn't happen on units deploying into units. The game appears to be forgetting that the object had a bomb on it.

##### STEPS TO REPRODUCE #####
Get a Crazy Ivan, place his bomb on your Con Yard, and undeploy your Con Yard. The bomb disappears.
Now place the bomb on MCV, and deploy the MCV. The bomb disappears again.
Magic!

##### ADDITIONAL INFORMATION #####
This happens both with and without Ares (tested with 0.1.823).

[GMBigB (gmbigb)]

This bug is no Ares issue, it happens with out without, but I would love to see it fixed for 0.2. It's ok to let the bomb trigger immediately if the unit deploys/undeploys.

Does someone know about that one? Put an ivan bomb on a conscript and let him enter the a transport vehicle. The timer keeps running, but the bomb does not explode until the infantry unit leaves the transport vehicle. This trick cannot be misused to an advantage though. Even 5 conscripts with ivan bombs cannot destroy a weapon factory or an ore refinery.

[cranium (cranium)]

It's been known for some time now, and while I dont see this as a problem since it is a normal function, meaning in between switching types-Building to unit, unit to building, I dont think theres anyway for it to transfer the IvanBomb information from one to the other. But then again, I'm no coder so I wouldnt really know. Maybe add a tag to the IvanBomb code to prevent deploy/undeploy of these types of buildings/units once bomb is placed? like the dron, when it enters the mcv it cannot deploy anymore.

[GMBigB (gmbigb)]

I agree. The best is to prevent the unit from being deployed/undeployed if it has an ivan bomb. In addition, it should be impossible to sell a building with an ivan bomb.

[Bug Importer (bug-importer)]

Code related to this issue has just been checked in!
Author: DCoder
Location: various-fixes, r1076
Commit contains DLL: Yes
Revision comment:
Related to issue #1257 - ivan bombs are transferred between units and structures during deploy process. Bomb will detonate if rigged unit or building is sold.
SVN: http://svn.renegadeprojects.com/Ares/1076

[DCoder DCoder (dcoder1337)]

Marking as resolved fixed - your turn, testers.

[FS-21 (jagarni1983)]

I tested this r1076 in these cases succesfully:
- Bombs are transferred between units and structures & vice-versa during deploy/undeploy process with salve miners & only the deploy case with undeployable buildings.
- When I sold a building it exploded in the end of the sell animation.

[YR M0ddEr (yr-m0dder)]

Got the same results as FS-21. Seems fixed to me. Works fine with sellunit and others(such as chrono prison)

[cranium (cranium)]

ha, this shit is awsome. Works great guys.

Will this Various Fixes Branch be included in 0.2? "has fingers crossed"

[Rogan (pdrogan)]

Tried this with my own MCV. The bomb is still there even when deploying or undeploying the MCV.

It blows up when I sell the MCV.

This issue is as good as done.

[DCoder DCoder (dcoder1337)]

Issue will be closed in a few days if no problems are found.

As for 0.2 inclusion, I don't know yet, we'll need to discuss this with other coders.

[Bug Importer (bug-importer)]

Code related to this issue has just been checked in!
Author: DCoder
Location: various-fixes, r1079
Commit contains DLL: Yes
Revision comment:
Related to issue #1257 - Ivan bombs used to disappear when their victim building changed sides, should not happen anymore.
SVN: http://svn.renegadeprojects.com/Ares/1079

[YR M0ddEr (yr-m0dder)]

Ivan bombs no longer dissappear when building with Ivan bomb change side.

[mevitar (mevitar)]

Confirming that Ivan bombs stay on buildings switching side (tested with engineers and mind control).

[Chanterier (speederyr)]

Yup, bombs remain on units which deploy into buildings, vice versa and when a building switches sides. They also explode when building is sold at the very moment structure disappears.

[Rogan (pdrogan)]

The Ivan bomb stays on the target on a building that is about to switch sides. I get the same result with deployinto vehicles and buildings.

[DCoder DCoder (dcoder1337)]

I think that's enough confirmations to close this.

[DCoder DCoder (dcoder1337)]

Some dumbass (read: me) removed the main part of this fix from the main build when removing code related to mind control transfer (bug 895438). It has now been restored, and branches v02 and v02-mix3 have been rebuilt to include it. Thus, we need confirmations that this functionality once again works as it should.

[Graion Dilach (graiondilach)]

Restoration works as should.