NCO bug returns in a new form

[mevitar]

In 16.11.1273, as put on PPM Forum, "Whenever units change owner, are killed, put, or discovered, the construction options will be rechecked".

However, this causes EVA to say "New Construction Options" each time any (literally any) unit is created. It also happens each time a factory is added/removed from the map (like: even if there are 3 factories, if something happens to even one of them, EVA will make this announcement, even if the other 2 factories can produce stuff normally).

In 0.A and before, the NCO announcement happened only when there were actually new buildable objects added or removed.

[AlexB (alexander-b)]

Factory functions have been reworked and the NCO check Ares added has been altered, because it was inefficient. In particular, a return value has changed, which is what now makes the NCO more obvious. Check the debug.log. there should be lines with the marker "[NCO Bug detected]".

I've changed the return value in case of NCO to the previous value for the next release, and this should not happen any more.

[mevitar (mevitar)]

It's fixed in 16.15.1117. The [NCO Bug detected] still appears in the debug.log, but like before 0.B, it doesn't give the EVA announcement.

BTW, the said [NCO Bug detected] was due to an oversight of mine, since certain units required a factory i apparently removed from the building list. Since the only thing that prevented the units from being built was having that factory as their prerequisite, removing it caused this warning to appear in the log. However, only once the NCO check was rewritten it turned into an actual ingame EVA announcement.

I removed the said units in the end (they weren't supposed to be buildable anyway), but it might be important why this issue happened.

[AlexB (alexander-b)]

Thanks for testing! This is as it should be. The important thing is that the message is logged. Having EVA erratically emit NCOs all the time is a good and very audible indicator that there's a coding error in the INIs somewhere, but for players this is just undesirable.