DeploysInto & BuildLimit issues

[Starkku]

Ares made BuildingType defined in DeploysInto flag of a VehicleType count towards the BuildLimit of the vehicle. While this sort of works, it has some issues. Namely the fact that if BuildLimit has been reached and you have atleast 1 of those vehicles deployed into a vehicle, you are able to queue more vehicles, altough it won't be building any. There's also another isssue with queue related to this which is best described through an example. In the following example, the vehicle has BuildLimit=5.

1. Build 5 of the vehicle in question.
2. Deploy them all, destroy/sell one of them.
3. You can now queue 4 more and actually build them, for some bizarre reason. It allows you to circumvent the build limit.
4. Deploy the newly built vehicles. If you destroy enough of them again so you have less than 5 (or whatever your BL is) of them, you can repeat step 3.

This technically allows you to have up to (BuildLimit-1)*2 instances of the unit/building on the map at once.

Tested using 13.19.1183 (0.3 testing build).

[mevitar (mevitar)]

Confirming it, but i'll expand on it a bit, because there are actually 2 issues at work here, one known already (i think).

For step 3: you can build 4 when 4 of those vehicles are deployed. If you undeploy one of them, you'll be able to queue 3. If you undeploy 2, you'll be able to queue 2. Undeploy 3, you can build only one. But If you'll undeploy all of them, you'll still be able to build one. That's because of the queuing issue the game has with building multiple units with BuildLimit. If not that, you'd be able to queue 5 units when 4 units exist and are all deployed.

But back to this issue, each time a unit with a BuildLimit is deployed into a structure, you'll be able to queue one more unit to bypass this limit. Deploy 2, you can now queue 2 more units! You built 2 new ones? Deploy them, you can build another 2! And then again. And again.

In the end, there's no limit to the amount of units you can build this way, as long as you careful not to have 5 of them undeployed (in their vehicle state) when a new one is produced.

[mevitar (mevitar)]

I can't reproduce this issue anymore with 15.351.1329. It appears to have been fixed.

[AlexB (alexander-b)]

Right, it has. It is one of several related issues I was working on, but I'm not sure whether to pack this into the already monstrous 0.A. Anyhow, this is the second confirmation of an unannounced bugfix working, so I guess it is ok to cram it in.