bzr uncommit -r python crash 'CHKInventoryRepository' object has no attribute 'iter_reverse_revision_history'

[Nicolas PLANEL]

Distro : Arch Linux

bzr --version
Bazaar (bzr) 2.6.0
  Python interpreter: /usr/bin/python2 2.7.10
  Python standard library: /usr/lib/python2.7
  Platform: Linux-4.0.5-1-ARCH-x86_64-with-glibc2.2.5
  bzrlib: /usr/lib/python2.7/site-packages/bzrlib

# bzr uncommit -r 5734
 5735 Nicolas PLANEL 2015-06-11
      Avoid memleak on ColorMap during normal usage

The above revision(s) will be removed.
Uncommit these revisions? ([y]es, [n]o): yes
bzr: ERROR: exceptions.AttributeError: 'CHKInventoryRepository' object has no attribute 'iter_reverse_revision_history'

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/bzrlib/commands.py", line 930, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/bzrlib/commands.py", line 1121, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.7/site-packages/bzrlib/commands.py", line 673, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.7/site-packages/bzrlib/commands.py", line 697, in run
    return self._operation.run_simple(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/bzrlib/cleanup.py", line 136, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/bzrlib/cleanup.py", line 166, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/bzrlib/builtins.py", line 5396, in run
    local, keep_tags)
  File "/usr/lib/python2.7/site-packages/bzrlib/builtins.py", line 5451, in _run
    revno=revno, local=local, keep_tags=keep_tags)
  File "/usr/lib/python2.7/site-packages/bzrlib/uncommit.py", line 132, in uncommit
    hook_new_tip)
  File "/usr/lib/python2.7/site-packages/bzrlib/plugins/gtk/__init__.py", line 143, in save_commit_messages
    commit.save_commit_messages(*args)
  File "/usr/lib/python2.7/site-packages/bzrlib/plugins/gtk/commit.py", line 874, in save_commit_messages
    revid_iterator = b.repository.iter_reverse_revision_history(old_revid)
AttributeError: 'CHKInventoryRepository' object has no attribute 'iter_reverse_revision_history'

bzr 2.6.0 on python 2.7.10 (Linux-4.0.5-1-ARCH-x86_64-with-glibc2.2.5)
arguments: ['/usr/bin/bzr', 'uncommit', '-r', '5734']
plugins: bash_completion[2.6.0], changelog_merge[2.6.0], grep[2.6.0],
    gtk[0.100.0], launchpad[2.6.0], netrc_credential_store[2.6.0],
    news_merge[2.6.0], po_merge[2.6.0], weave_fmt[2.6.0]
encoding: 'utf-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'

*** Bazaar has encountered an internal error. This probably indicates a
    bug in Bazaar. You can help us fix it by filing a bug report at
        https://bugs.launchpad.net/bzr/+filebug
    including this traceback and a description of the problem.

[Nicolas PLANEL (nicolas-planel)]

bug if already fixed in bzr-gtk

as iter_reverse_revision_history method is deprecated :
repository.iter_reverse_revision_history() has been replaced by Graph.iter_lefthand_ancestry()

[Nicolas PLANEL (nicolas-planel)]

Bug still exist in package Arch Linux bzr-gtk 0.100.0-2

Fixup attached and email sent to the ML <email address hidden> as the package don't have official maintainer.

[Johannes Dewender (jonnyjd)]

The Arch Linux package does haven an official maintainer was informed and the official page for the package is:
https://aur.archlinux.org/packages/bzr-gtk/
(and currently https://aur4.archlinux.org/packages/bzr-gtk/; there is a transition going on)

[Johannes Dewender (jonnyjd)]

You say this is already fixed in bzr-gtk, but I can't find the fix or the code your patch is based on in https://code.launchpad.net/~bzr-gtk/bzr-gtk/gtk3

When you say this is already fixed in bzr-gtk you mean it is fixed in the gtk3 series, right?
Because in:
https://code.launchpad.net/~bzr-gtk/bzr-gtk/gtk2 (where 0.100 resides) I can't find the fix.

So this is a workaround and the real fix is to upgrade to the gtk3 series and 0.103, right?

[Nicolas PLANEL (nicolas-planel)]

Yes it's not fixed in gtk2 branch, my patch will. I suspect there are others potential bugs as the gtk2 branch seems not up to date.
It will more simple for the bzr-gtk package to switch to the gtk3 branch as it's the latest up to date, supported branch.