Bright colors are broken on Sakura 3.3.0

[Alexander Harvey]

Something between Sakura 3.2.0 and 3.3.0 messed up the color palette. Here's a screenshot of Sakura 3.2.0 on the left and 3.3.0 on the right with a shared screen -x session using the "Linux" color palette.

[Andreas Rönnquist (gusnan)]

I have a Debian stable machine, and a Debian unstable virtual machine, both with sakura 3.3.3 built from source - and only the Debian unstable machine shows the reported behavior. Is it perhaps something that has changed in later versions of libvte or other libraries sakura depend on?

[Torbjörn Lönnemark (tobbez)]

Happens on Ubuntu 19.04, where the cause seems to be: https://bugzilla.gnome.org/show_bug.cgi?id=762247.

Confirmed by adding `vte_terminal_set_bold_is_bright(VTE_TERMINAL(term->vte), true);` inside the loop in sakura_set_colors, which restores the previous behaviour.

It should probably be exposed as an option.

[David Gómez (dabisu)]

Added hidden command line option (--bold-is-bright) to call vte_terminal_set_bold_is_bright. If this fixes the problem, please let me know leaving a comment in this bug, thanks.

[Sergey Popov (fil0soff)]

The --bold-is-bright fixes the issue for me, but only for the first tab.
Text is not bright inside the second tab.
Moving "vte_terminal_set_bold_is_bright()" inside the loop in sakura_set_colors fixes it for me.