Additional pkexec support, .desktop file, aptik-launcher, aptik-uninstall
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Aptik |
Fix Released
|
Low
|
Tony George |
Bug Description
I noticed aptik removed the dependency on gksu which is good as it has not been updated in years and is deprecated. I have made some minor changes to aptik's packaging.
I've added a polkit profile so that aptik can be launched with pkexec (the successor to gksu) and show a nice prompt. I updated aptik-launcher accordingly and cleaned it up a little. I also cleaned up aptik-uninstall. They are both now shellcheck compliant.
Also I noticed the syntax `su - -c "${app_command}"` used in several places. I'm not familiar with su but I checked the manpages and it says: "When - is used, it must be specified as the last su option. The other forms (-l and --login) do not have this restriction."
So I'm not certain, but you may want to change that. The original command did not work for me whereas `su -l "$USER" -c -- ${app_command}` worked fine.
Lastly, there was a field named 'Caption' within aptik.desktop. Under FreeDesktop standards, this should be 'Comment'.
This was added in recent versions (16.4.3). Thanks.