Parse feedback page for branch information

Bug #1012064 reported by Daniel Holbach
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu Apps Brancher
Fix Released
High
Daniel Holbach

Bug Description

<ajmitch> in a few cases the submitter has a branch already
 it'd be cool to parse the initial comment & look for a lp: ;)

Related branches

Revision history for this message
Andrew Mitchell (ajmitch) wrote :

This case also comes up when the ARB has asked for source after they've initially submitted a binary package.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Maybe we can try to come up with some regexes or a priority of where first to look?

Changed in apps-brancher:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Daniel Holbach (dholbach) wrote :

Can somebody please help me testing a bunch of myApps pages, so we can figure out if the regexes in http://bazaar.launchpad.net/~dholbach/apps-brancher/1012064/revision/52 are correct? Just throw some HTML from myApps at them and see what they spit out for you.

Changed in apps-brancher:
assignee: nobody → Daniel Holbach (dholbach)
status: Confirmed → In Progress
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

In find_ppa_info(), I'd expect to see ""ppa:%s/%s" % (slug_regex, slug_regex)" on line 95 not "lp:%s/%s" % (slug_regex, slug_regex)"

I tried to give this a test, but it's not working for me:

>>> from brancher import web; import urllib
>>>
>>> html=urllib.urlopen("https://myapps.developer.ubuntu.com/dev/apps/500/feedback/")
>>> web.find_ppa_info(html)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "brancher/web.py", line 98, in find_ppa_info
    ppas = re.findall("(%s)" % "|".join(ppa_regexes), html)
  File "/usr/lib/python2.7/re.py", line 177, in findall
    return _compile(pattern, flags).findall(string)
TypeError: expected string or buffer

Revision history for this message
Daniel Holbach (dholbach) wrote : Re: [Bug 1012064] Re: Parse feedback page / initial comment for branch/ppa information

On 22.06.2012 16:37, Andrew Starr-Bochicchio wrote:
> In find_ppa_info(), I'd expect to see ""ppa:%s/%s" % (slug_regex,
> slug_regex)" on line 95 not "lp:%s/%s" % (slug_regex, slug_regex)"

I'll have a look into it. Thanks.

> I tried to give this a test, but it's not working for me:
>
>>>> from brancher import web; import urllib
>>>>
>>>> html=urllib.urlopen("https://myapps.developer.ubuntu.com/dev/apps/500/feedback/")

Oops, this is missing a .read() a the end.

Have a great day,
 Daniel

summary: - Parse feedback page / initial comment for branch/ppa information
+ Parse feedback page for branch information
Changed in apps-brancher:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.