Broken contact URL in German translation

[Benjamin Drung]

Impact
------

All German users (and all translations that use "%s." in their translation template) will get a broken URL link for bug reports against snaps (e.g. Firefox).

Test Case
---------

1. Execute following command: LANGUAGE=de ubuntu-bug firefox
2. Click on the URL
3. A browser window should open and not display a 404 page

Regression Potential
--------------------

Since there was no test case for converting text to HTML before this fix, there might be some URLs that will become broken by this fix.

Original Description
--------------------

"LANGUAGE=de ubuntu-bug firefox" end up in a dialog saying:

firefox wird durch einen von mozilla veröffentlichten Snap bereitgestellt. Für Hilfe gehen Sie über https://support.mozilla.org/kb/file-bug-report-or-feature-request-mozilla.

The dot at the end is included in the URL link. The dot makes the URL link broken. The regular expression in gtk/apport-gtk for http URLs should become smarter.

[Benjamin Drung (bdrung)]

Fixed: https://github.com/canonical/apport/commit/e0a90520b84d8c46b1474fb3c9421d72e3a99960

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.22.0-0ubuntu1

---------------
apport (2.22.0-0ubuntu1) kinetic; urgency=medium

  * New upstream release:
    - Replace `ProblemReport.get_date` by `ProblemReport.get_timestamp`, fixes
      regression in 2.21.0 (LP: #1978487)
    - apport-gtk: Exclude trailing dot from URL links (LP: #1978301)
    - Fix `AttributeError`: 'NoneType' object has no attribute 'write', fixes
      regression in 2.21.0 (LP: #1979211)
    - apport_python_hook: Properly handle missing modules (LP: #1774843)
    - apport_python_hook: Fix FileNotFoundError if the current directory was
      deleted (LP: #1979637)
    - apport_python_hook: Fix crash if os.getcwd() fails (LP: #1977954)
    - Replace deprecated 'imp' module (LP: #1947425)
    - whoopsie-upload-all: Fix 'EOFError' object has no attribute 'errno',
      fixes regression in 2.21.0 (LP: #1979681)
  * Fix KeyError: 'CasperMD5json'

 -- Benjamin Drung <email address hidden> Mon, 27 Jun 2022 12:03:00 +0200

[Steve Langasek (vorlon)]

An upload of apport to jammy-proposed has been rejected from the upload queue for the following reason: "contains bugfixes without bug references or test cases, does not meet SRU policy".

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Benjamin Drung (bdrung)]

On 2022-12-15 I uploaded apport 2.20.11-0ubuntu82.4 to jammy to fix this bug.

[Steve Langasek (vorlon)]

The refactor of apport-gtk in the jammy queue includes this change:

- if not isinstance(text, bytes):
- text = text.encode('UTF-8')

This code is not included in the refactored function. Why is it safe to drop this code?

[Benjamin Drung (bdrung)]

The reason for that is described in the git commit message: "`GLib.markup_escape_text` takes a
`str` as well. So converting `text` to `bytes` is not needed." That claim is verified by the added test cases.

[Steve Langasek (vorlon)]

Hello Benjamin, or anyone else affected,

Accepted apport into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apport/2.20.11-0ubuntu82.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Benjamin Drung (bdrung)]

Verified apport 2.20.11-0ubuntu82.5 in a jammy VM as good as possible. The German translation removed the dot at the end in the meantime. The links displayed in the presented window is correct.

Sadly there seems to be a regression somewhere else: Clicking on the link did not open the browser window, but causes these error messages (identical behavior to apport 2.20.11-0ubuntu82.4):

```
$ LANGUAGE=de ubuntu-bug firefox
grep: /proc/sys/fs/binfmt_misc/WSLInterop: No such file or directory
WSL Interopability is disabled. Please enable it before using WSL.
grep: /proc/sys/fs/binfmt_misc/WSLInterop: No such file or directory
[error] WSL Interoperability is disabled. Please enable it before using WSL.
/usr/bin/wslview: line 216: /mnt/c/Windows/System32/reg.exe: No such file or directory
/usr/bin/wslview: line 149: /mnt/c/Windows/System32/chcp.com: No such file or directory
/usr/bin/wslview: line 156: /mnt/c/Windows/System32/WindowsPowerShell/v1.0/powershell.exe: No such file or directory
/usr/bin/wslview: line 149: /mnt/c/Windows/System32/chcp.com: No such file or directory
```

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.20.11-0ubuntu82.5

---------------
apport (2.20.11-0ubuntu82.5) jammy; urgency=medium

  * apport-gtk: Exclude trailing dot from URL links (LP: #1978301)
  * apport-bug: Add /snap/bin to PATH for Firefox snap on Lubuntu
    (LP: #1973470)
  * test:
    - Clear environment for test_run_as_real_user_no_sudo
    - Fix GTK UI tests if whoopsie.path is disabled
    - tests: Fix GTK UI race condition and reduce timeout again, saving
      five minutes test execution time (LP: #1780767)
    - tests: Fix race in tests for run_report_bug()

 -- Benjamin Drung <email address hidden> Fri, 14 Apr 2023 01:08:26 +0200

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for apport has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.