appmenu-qt should use async dbus calls

Bug #1096008 reported by Cédric Bellegarde on 2013-01-04
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
appmenu-qt
Fix Committed
Undecided
Unassigned
appmenu-qt (Ubuntu)
Undecided
Unassigned

Bug Description

Here a patch fixing issues in KDE 4.10...

It make appmenu-qt use async dbus introspection preventing dbus locks...

http://lists.kde.org/?l=kde-core-devel&m=135729000730025&w=4

Should be cool to be applied and released for KDE 4.10 ;)

Related branches

Cédric Bellegarde (gnumdk) wrote :
Cédric Bellegarde (gnumdk) wrote :

ping ?

Sebastien Bacher (seb128) wrote :

Cédric: thanks for your work, sorry for the lack of reply but people are just returning from holidays and dealing with accumulated backlog, one week is not an unreasonable delay in opensource

Is there any chance you could submit a merge request for your patch?

If you didn't do one before, the steps are basically:
- bzr branch lp:appmenu-qt
- cd appmenu-qt
- do your changes
- bzr commit
- bzr push lp:~gnumdk/appmenu-qt/fix-1906008
- bzr lp-open

click on "propose for merging" on the launchpad page and file the description/commit message and submit

You have a better chance to get people noticing a pending merge request than a bug report comment, and it will make easier to merge the change ;-)

Cédric Bellegarde (gnumdk) wrote :

Ok, thanks for information. Will do that.

Changed in appmenu-qt:
status: New → Fix Committed

The attachment "Use async dbus menu calls" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Cédric Bellegarde (gnumdk) wrote :

See fix-service-isValid

Changed in appmenu-qt:
status: Fix Committed → New
Changed in appmenu-qt:
status: New → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package appmenu-qt - 0.2.7daily13.01.17-0ubuntu1

---------------
appmenu-qt (0.2.7daily13.01.17-0ubuntu1) raring; urgency=low

  [ Robert Bruce Park ]
  * Inline packaging metadata.

  [ Didier Roche ]
  * Automatic snapshot from revision 48 (bootstrap):

  [ <email address hidden>, Cédric Bellegarde ]
  * appmenu-qt should use async dbus calls (LP: #1096008)

  [ Automatic PS uploader ]
  * Automatic snapshot from revision 50
 -- Automatic PS uploader <email address hidden> Thu, 17 Jan 2013 02:00:52 +0000

Changed in appmenu-qt (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers