extra registrations create applications slowness

Bug #604668 reported by Sebastien Bacher
30
This bug affects 4 people
Affects Status Importance Assigned to Milestone
AppMenu GTK+
Fix Released
High
Cody Russell
appmenu-gtk (Ubuntu)
Fix Released
High
Cody Russell

Bug Description

Binary package hint: appmenu-gtk

<ted> $ bustle-time nautilusmenus.bustle
  5784.1740 243 23.8032 org.ayatana.dbusmenu.GetProperties
   712.0370 1 712.0370 org.ayatana.dbusmenu.GetLayout
    75.0190 292 0.2569 org.ayatana.WindowMenu.Registrar.RegisterWindow
 That's a nautilus window opening.

<ted> bratsche, It seems odd that nautilus is registering 292 time though -- there's probably a bug there.

Related branches

David Barth (dbarth)
Changed in appmenu-gtk:
assignee: nobody → Cody Russell (bratsche)
importance: Undecided → High
milestone: none → maverick-alpha-3
status: New → Triaged
Revision history for this message
Ted Gould (ted) wrote :

Here's a Bustle log showing the problem. It looks like Nautilus is registering for a full second (?!?!) in this case?

Revision history for this message
Ted Gould (ted) wrote :

I forgot to comment that the bustle log was taken with the property globing dbusmenu branch. Here's the updated time results:

$ bustle-time nautlius.openwindow.bustle
  997.9790 2 498.9895 org.ayatana.dbusmenu.GetLayout
   81.5700 292 0.2793 org.ayatana.WindowMenu.Registrar.RegisterWindow
   76.6040 2 38.3020 org.ayatana.dbusmenu.GetGroupProperties

David Barth (dbarth)
Changed in appmenu-gtk (Ubuntu):
assignee: nobody → Cody Russell (bratsche)
importance: Undecided → High
milestone: none → maverick-alpha-3
status: New → Triaged
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Is libdbusmenu not batching the the menu changes? If I read that bustle log correctly Nautilus is triggering a DBus call each time it touches the menu?

Cody Russell (bratsche)
Changed in appmenu-gtk:
status: Triaged → In Progress
Changed in appmenu-gtk (Ubuntu):
milestone: maverick-alpha-3 → ubuntu-10.10-beta
David Barth (dbarth)
Changed in appmenu-gtk:
milestone: maverick-alpha-3 → ubuntu-10.10-beta
Revision history for this message
Hernando Torque (htorque) wrote :

Not sure if this is connected, but I'm getting tons of warnings in ~/.xsession-errors when using Nautilus. This was just from some minutes of use:

test@test:~$ cat .xsession-errors | wc -l
945343
test@test:~$ cat .xsession-errors | grep -c "^$"
472656
test@test:~$ cat .xsession-errors | grep -c "G_IS_OBJECT"
392707
test@test:~$ cat .xsession-errors | grep -c "GtkLabel"
53948
test@test:~$ cat .xsession-errors | grep -c "PangoLayout"
19206

The warnings:
*) GLib-GObject-CRITICAL **: g_object_set: assertion `G_IS_OBJECT (object)' failed
*) GLib-GObject-WARNING **: g_object_set_valist: object class `GtkLabel' has no property named `ubuntu-local'
*) GLib-GObject-WARNING **: g_object_set_valist: object class `PangoLayout' has no property named `ubuntu-local'

Working just one hour in Nautilus caused the .xsession-error file to be 300 MiB large. No problems without appmenu-gtk.

Cody Russell (bratsche)
Changed in appmenu-gtk:
status: In Progress → Fix Released
Cody Russell (bratsche)
Changed in appmenu-gtk (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Hernando Torque (htorque) wrote :

FYI: ~/.xsession-errors no longer gets spammed by those warnings - well done! :-)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.