SYS_getdents undecleared for readdir regression test on arm64

Bug #1674245 reported by Po-Hsu Lin on 2017-03-20
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
AppArmor
Undecided
Colin Ian King
QA Regression Testing
Undecided
Unassigned

Bug Description

In the regression test, readdir.c will fail to compile on arm64 and fail the test_regression_testsuite test.

cc -g -O0 -Wall -Wstrict-prototypes readdir.c -lapparmor -o readdir
readdir.c: In function ‘main’:
readdir.c:45:14: error: ‘SYS_getdents’ undeclared (first use in this function)
  if (syscall(SYS_getdents, fd, &dir, sizeof(struct dirent)) == -1){
              ^~~~~~~~~~~~
readdir.c:45:14: note: each undeclared identifier is reported only once for each function it appears in
<builtin>: recipe for target 'readdir' failed
make: *** [readdir] Error 1

----------------------------------------------------------------------
Ran 55 tests in 1889.376s

FAILED (failures=1)

For arm64, there is only "SYS_getdents64" available:
$ grep -Ir SYS_getdents /usr/include/
/usr/include/aarch64-linux-gnu/bits/syscall.h:#define SYS_getdents64 __NR_getdents64
/usr/include/aarch64-linux-gnu/bits/syscall.h:#define SYS_getdents64 __NR_getdents64

Related branches

Po-Hsu Lin (cypressyew) on 2017-04-04
Changed in apparmor:
assignee: nobody → Colin Ian King (colin-king)
Changed in apparmor:
status: New → Fix Committed
Steve Beattie (sbeattie) wrote :

Patch added to q-r-t in commit https://git.launchpad.net/qa-regression-testing/commit/?id=52f39f87176843398bce2190d96a5aad0da2bf4f so is available for the kernel autotests.

Closing the qrt task.

Changed in apparmor:
milestone: none → 2.11.1
Changed in qa-regression-testing:
status: New → Fix Released
Colin Ian King (colin-king) wrote :

@Po-Hsu Lin is this still an issue or can we close this now?

Changed in apparmor:
status: Fix Committed → Incomplete
Po-Hsu Lin (cypressyew) wrote :

Hi Colin,

Just verified again manually on a ARM64 node. I can't see this SYS_getdents error message anymore.
Thank you!

Changed in apparmor:
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers