Charm is missing jammy support
Bug #1986516 reported by
Barry Price
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Apache2 Charm |
Fix Released
|
Medium
|
Simone Pelosi | ||
Bug Description
Charm is missing jammy (Ubuntu 22.04 LTS) support from its metadata.yaml
Related branches
~pelpsi/apache2-charm:python3-migration
- Tom Haddon: Approve
- Barry Price: Approve
- Diko Parvanov (community): Approve
- Junien F: Pending requested
-
Diff: 714 lines (+239/-89)17 files modifiedMakefile (+27/-5)
README.md (+7/-0)
charmcraft.yaml (+35/-0)
data/openssl.cnf (+1/-1)
hooks/charmhelpers/osplatform.py (+12/-0)
hooks/hooks.py (+45/-22)
hooks/install (+4/-10)
hooks/logging-relation-broken (+1/-0)
hooks/logging-relation-changed (+1/-0)
hooks/logging-relation-departed (+1/-0)
hooks/logging-relation-joined (+1/-0)
hooks/tests/test_balancer_hook.py (+60/-25)
hooks/tests/test_config_changed.py (+1/-0)
hooks/tests/test_create_vhost.py (+5/-5)
hooks/tests/test_vhost_config_relation.py (+34/-19)
metadata.yaml (+3/-1)
revision (+1/-1)
~dparv/apache2-charm:python3
- Junien F: Needs Information
- Canonical IS Reviewers: Pending requested
-
Diff: 178 lines (+27/-32)4 files modifiedMakefile (+8/-8)
hooks/hooks.py (+14/-14)
hooks/install (+4/-10)
metadata.yaml (+1/-0)
Revision history for this message
| Barry Price (barryprice) wrote | #1 |
Revision history for this message
| Barry Price (barryprice) wrote | #2 |
Revision history for this message
| Tom Haddon (mthaddon) wrote | #3 |
| Changed in apache2-charm: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
Revision history for this message
| Brian Murray (brian-murray) wrote | #4 |
| Changed in apache2-charm: | |
| assignee: | nobody → Simone Pelosi (pelpsi) |
| status: | Confirmed → In Progress |
Revision history for this message
| Tom Haddon (mthaddon) wrote | #5 |
| Changed in apache2-charm: | |
| status: | In Progress → Fix Committed |
| Changed in apache2-charm: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Looked into this, it's far from a trivial fix.
The whole charm is written in python2, and relies on python2-specific packages that no longer exist in jammy.
Furthermore, the test suite uses nose, which "has been in maintenance mode for the past several years"[1]. As that site also notes, "nose itself supports python 3, but many 3rd-party plugins do not!". This may be why bootstrapping the existing test suite seems to fail using python3 (in a trusty LXD).
To resolve this, we'll need to update all the actual charm code to python3, and ideally port the test suite to use tox/pytest too, to bring it in line with other charms.
Porting to reactive (or operator) may not be that much more work given the above, and would bring this more in line with other charms.
[1] https:/