'clean' option can go in the way of the build

[Georges Racinet]

The 'clean' option performs an aggressive cleaning, including VCS ignored files. The main use case so far being continuous integration bots and is indeed systematically passed by anybox.buildbot.openerp

In cases where the buildout is also an addon, a pattern which is useful to ship the testing harness in the same repository as the tested addons directory (also meant for CI), it goes as far as to remove buildout-generated technical directories, such as 'develop-eggs'.
This is currently demonstrated with the newly uploaded 'advanced_attachment'.

Buildout configuration:

addons = bzr lp:openobject-addons/7.0 addons-openerp last:1
         bzr lp:openerp-web/7.0 addons-web last:1 subdir=addons
         local .

It works well on a developer's box, but ends like this in the buildbot :

Traceback (most recent call last):
(...)
  File "/srv/buildslave/buildbot.anybox.r/buildout-caches/eggs/anybox.recipe.openerp-1.8.2-py2.7.egg/anybox/recipe/openerp/server.py", line 110, in merge_requirements
    self.develop(openerp_dir, setup_has_pil=setup_has_pil)
  File "/srv/buildslave/buildbot.anybox.r/buildout-caches/eggs/anybox.recipe.openerp-1.8.2-py2.7.egg/anybox/recipe/openerp/base.py", line 436, in develop
    zc.buildout.easy_install.develop(setup, develop_dir)
  File "/srv/buildslave/buildbot.anybox.r/buildout-caches/eggs/zc.buildout-2.2.1-py2.7.egg/zc/buildout/easy_install.py", line 887, in develop
    tmp3 = tempfile.mkdtemp('build', dir=dest)
  File "/usr/lib/python2.7/tempfile.py", line 325, in mkdtemp
    _os.mkdir(file, 0700)
OSError: [Errno 2] No such file or directory: '/srv/buildslave/buildbot.anybox.r/advanced_attachment-postgresql-9_2/build/develop-eggs/tmpQO9Pbkbuild'

Note that a locally provided 'develop' distribution (with the 'develop' directive in buildout.cfg) would have the same problem.

At least, the default implementation of clean (rthat's used for a local addon, removes .pycfiles and subsequent empy directories) should exclude buildout's technical directories, such as this one.

In the meanwhile, this can probably be circumvented by placing a placeholder file in the needed directories.

[Georges Racinet (gracinet)]

I confirm that committing a placeholder file in develop-eggs circumvents the problem (hence low importance).

[Georges Racinet (gracinet)]

'clean' should also exclude all addons directories and the parts directory (the latter being one of those technical ones)

[Georges Racinet (gracinet)]

This can wait for 1.8.4, and I'm currently the only one that stumbled on it

[Georges Racinet (gracinet)]

It'll wait a bit more

[Georges Racinet (gracinet)]

Can wait a bit