Eclipse toolbar: bigger space around toolbar icons

[Chris Mattes]

See screenshot,
the left part is Eclipse running with the Dust theme (similar to other themes), the right side is the New Wave theme

[Dilomo (ankere)]

Working to see if this is fixable! Expect a patch soon.

[Thomas Trummer (truetom)]

style "newwave-toolbar-noimage"
{
    GtkToolbar :: internal-padding = 0
    ...

Though, I have to move the perspective tab to the left like in your screenshot in order to get the smallest toolbar...

[Dilomo (ankere)]

Thomas - your suggestion is right :) Though I think it is better to separate it in different "method" or style as other applications are using this.

Chris - I attach a patch to the theme (light menus). Can you paste the file in the themes folder? If you don't know how (and where to search) I will make you a screencast and upload it here.

[Chris Mattes (christian-mattes)]

Looks better now, there's less empty space between the buttons now :)

Great! And thanks to you I'm beginning to learn how GTK-themes are working :)

[Dilomo (ankere)]

So you found where to paste it? Good :) and you see GTK themes are not so complex.

[Chris Mattes (christian-mattes)]

Hmm, maybe there is another problem now.

If I use the provided gtkrc, my Eclipse gets very slow and 'top' reports 100% CPU load for it.
Switching to the previous gtkrc solves this...

The effect can be achieved by simply changing the gtkrc file and restarting Eclipse, no GNOME restart or something else.

[Dilomo (ankere)]

That is absolutely strange. Is this happening with 0.7.2b1?
Here's a link to the download: https://launchpad.net/anton/+download

I attach another gtkrc file to be tested. I may even install eclipse if that doesn't work.

[Thomas Trummer (truetom)]

I can confirm that. GtkToolbar::internal-padding = 1 works on the other hand...

[Dilomo (ankere)]

So I'm just going to use this Thomas. Btw I tried to use inheritance of styles but it does not work too.

I upload a updated version Chris. Can you upload a screenshot of the program so that I can see how it looks?

[Dilomo (ankere)]

See the downloads of the project's main page.

[Chris Mattes (christian-mattes)]

I'm still getting the 100% load with version 0.72. This didn't happen with 0.72b1.

Now the buttons are almost too small, they're not square any more.

[Dilomo (ankere)]

Try this download:

http://gnome-look.org/content/show.php/New+Wave?content=87134

This one at this site is old an contains some mistakes. Btw what is your distro?

[Chris Mattes (christian-mattes)]

Sorry, no change with the version from Gnome-Look :-(

I'm using Ubuntu 8.10

[Chris Mattes (christian-mattes)]

Forgot to mention: I have Compiz running with Desktop Effects turned on.

I just took the gtkrc from 0.72b1 and changed the line Thomas mentioned.
If I set GtkToolbar::internal-padding to 1, Eclipse works fine, if I set it to 0 I get 100% CPU-load.

[Dilomo (ankere)]

But I fixed this in the gnome-look version! Which of the three theme are you using. Please attach the pakc here!

[Dilomo (ankere)]

I commited a patch and soon a new bugfix version (0.7.3) will be available for download.

[Dilomo (ankere)]

Check this out http://gnome-look.org/content/show.php/New+Wave?content=87134

[Chris Mattes (christian-mattes)]

Looks good now, and no problems with Eclipse anymore.
Java-development with such a cool Look&Feel is great :-)

Thanks!

[Dilomo (ankere)]

Me too thanks for the valuable feedback!

If you find another bug you know where to write ;)