vhalReady callback in the streaming SDK is called too early

Bug #2061741 reported by Michele Lo Russo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Anbox Cloud
Fix Released
Medium
Michele Lo Russo

Bug Description

The vhalReady callback was being called right after initialising the AnboxVhalManager. However, at this point, we still have not received any prop configs from Anbox. These can arrive with an imperceptible delay, but in some cases they are received after many seconds, giving enough time to the consumer (e.g. the dashboard) to try to call methods like getPropConfigs or getAllPropConfigs - thinking that "VHAL is ready" - and receiving an empty array response.

Steps to reproduce:

1. Go to the demo server page for the PR that introduces the usage of the new vhalReady callback: https://anbox-cloud-dashboard-777.demos.haus/sessions
2. Join an AAOS session.
3. As soon as the VHAL panel opens, and before the stream loads, click on the "All VHAL properties" button in the panel.
4. See that the the list of received VHAL prop configs is empty. Before, the UI used to freeze (as shown in the attached screen captures), but this was caused by an uncontrolled rerendering loop that could be fixed, and is technically not strictly related to the issue above.

Revision history for this message
Michele Lo Russo (lorumic) wrote :
Revision history for this message
Alexis Janon (ajanon) wrote :
Changed in anbox-cloud:
milestone: none → 1.22.0
importance: Undecided → Medium
status: New → Triaged
description: updated
Changed in anbox-cloud:
assignee: nobody → Michele Lo Russo (lorumic)
status: Triaged → In Progress
summary: - Dashboard: streaming page freezes due to never-returning VHAL getters in
- the streaming SDK
+ vhalReady callback in the streaming SDK is called too early
Changed in anbox-cloud:
status: In Progress → Fix Committed
Simon Fels (morphis)
Changed in anbox-cloud:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.