Ampoule logging is exceedingly verbose
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ampoule |
New
|
Undecided
|
Unassigned |
Bug Description
Ampoule copies each child's output into the parent's log output. Since the child is also using Twisted logging, this results in log messages with lots of duplicate information. For example,
2010-04-03 15:11:04-0400 [-] FROM 0: 2010-04-03 15:11:04-0400 [HTMLOnlyPageGe
This would be better if the redundancy were elided. For example, formatting the above event like this instead would a bit of an improvement:
2010-04-03 15:11:04-0400 [Ampoule 0,HTMLOnlyPageG
This preserves all of the information, but presents it better.
One approach which could work to implement this would be to have the child processes use a different logger. Rather than writing to stdout, it could make AMP calls back onto the parent with the log information.
Meanwhile, the parent would implement a receiver for these logging commands which re-published them to the log observer in the parent. The system keyword argument to log.msg can be used to make sure the information about which child the event is from is preserved.