Ampoule doesn't work < python2.5

[Blair Bethwaite]

After _a lot_ of mucking around making setuptools work (because Ampoule wanted it) on an old FC4 box I finally was able to proceed with the install. Much to my surprise this included downloading and installing Twisted, the same version already installed on the system - though I imagine this duplication is the fault of setuptools itself.

During this install I saw [1]. Anyhow the install proceeded and exited cleanly, so I tried ampoule and was greeted by [2]. I guess yield has changed or wasn't supported before python2.5 - now that I think about it this is probably a bigger problem if it affects Twisted, but it nevertheless seems to break Ampoule

[1]
Downloading http://tmrc.mit.edu/mirror/twisted/Twisted/8.2/Twisted-8.2.0.tar.bz2#md5=c85f151999df3ecf04c49a781b4438d2
Processing Twisted-8.2.0.tar.bz2
Running Twisted-8.2.0/setup.py -q bdist_egg --dist-dir /tmp/easy_install--UxITk/Twisted-8.2.0/egg-dist-tmp-A9O7-p
twisted/protocols/_c_urlarg.c: In function ‘unquote’:
twisted/protocols/_c_urlarg.c:65: warning: pointer targets in passing argument 2 of ‘PycStringIO->cwrite’ differ in signedness
twisted/protocols/_c_urlarg.c:75: warning: pointer targets in passing argument 2 of ‘PycStringIO->cwrite’ differ in signedness
twisted/protocols/_c_urlarg.c:83: warning: pointer targets in passing argument 2 of ‘PycStringIO->cwrite’ differ in signedness
twisted/protocols/_c_urlarg.c:85: warning: pointer targets in passing argument 2 of ‘PycStringIO->cwrite’ differ in signedness
twisted/protocols/_c_urlarg.c:93: warning: pointer targets in passing argument 2 of ‘PycStringIO->cwrite’ differ in signedness
twisted/protocols/_c_urlarg.c:96: warning: pointer targets in passing argument 2 of ‘PycStringIO->cwrite’ differ in signedness
twisted/protocols/_c_urlarg.c:97: warning: pointer targets in passing argument 2 of ‘PycStringIO->cwrite’ differ in signedness
  File "build/bdist.linux-i686/egg/twisted/test/generator_failure_tests.py", line 66
    yield
         ^
SyntaxError: invalid syntax
  File "/usr/lib/python2.4/site-packages/Twisted-8.2.0-py2.4-linux-i686.egg/twisted/test/generator_failure_tests.py", line 66
    yield
         ^
SyntaxError: invalid syntax
  File "/usr/lib/python2.4/site-packages/Twisted-8.2.0-py2.4-linux-i686.egg/twisted/test/generator_failure_tests.py", line 66
    yield
         ^
SyntaxError: invalid syntax
Adding Twisted 8.2.0 to easy-install.pth file
Installing pyhtmlizer script to /usr/bin
Installing cftp script to /usr/bin
Installing ckeygen script to /usr/bin
Installing manhole script to /usr/bin
Installing tap2deb script to /usr/bin

[2]
[blair@nimrod1 ampoule-0.1]$ python examples/pid.py
  File "examples/pid.py", line 26
    result = yield pp.doWork(Pid)
                 ^
SyntaxError: invalid syntax

[dialtone (dialtone)]

Notice that the error comes from an example, not from internal ampoule code. Anyway there are a couple of places in the code that stops a process that affect ampoule, I fixed those. Note however that I don't have Python 2.4 and the testsuite runs on Python 2.4. I'm not going to change the examples because they don't work on Python 2.4 so if you want to do a report please use the tests and tell me which are failing.

in head there's a fix that should make ampoule work with python 2.4 though, although there might be other problems.