Source code an Gentoo QA

Bug #421098 reported by Fabiano Francesconi on 2009-08-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Alarm Clock
Fix Released
Low
Johannes H. Jensen

Bug Description

Hi.
I saw your applet and I decided to create en ebuild for it in order to add it to portage tree.
ATM it's currently hosted on gentoo-sunrise overlay (if you want to check it out please visit: https://bugs.gentoo.org/283022).

Ebuild system, during compiling process, claims about what it describe as 'poor programming practices'.
This means that your code could be improved in order to fit Gentoo QA.

Would be really nice if you fix your code in order to make it compile properly and better.

 * QA Notice: Package has poor programming practices which may compile
 * fine but exhibit random runtime failures.
 * alarm-gconf.c:171: warning: implicit declaration of function 'list_alarms_update'
 * ui.c:233: warning: implicit declaration of function 'alarm_applet_snooze_alarms'
 * alarm-applet.c:500: warning: implicit declaration of function 'list_alarms_dialog_close'
 * alarm.c:1114: warning: implicit declaration of function 'alarm_is_playing'
 * alarms-list.c:261: warning: implicit declaration of function 'alarm_is_playing'
 * edit-alarm.c:854: warning: implicit declaration of function 'alarm_bind'

Furthermore I saw a lot of "unused variables" in the code. You should removed them before releasing a final version. Just my advice.

Let me know something and keep going on with this brilliant applet :)

Fabiano 'elbryan' Francesconi

Johannes H. Jensen (joh) on 2009-10-28
Changed in alarm-clock:
importance: Undecided → Low
Johannes H. Jensen (joh) on 2010-01-02
Changed in alarm-clock:
assignee: nobody → Johannes H. Jensen (joh)
milestone: none → 0.3
status: New → Confirmed
Johannes H. Jensen (joh) on 2010-03-06
Changed in alarm-clock:
status: Confirmed → Fix Committed
Johannes H. Jensen (joh) on 2010-03-16
Changed in alarm-clock:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers