Comments on Database Objects Not Supported

Bug #851535 reported by Padraig O'Sullivan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Akiban SQL Parser
Low
Mike McMahon

Bug Description

Comments on database objects as supported through PostgreSQL are not currently supported through Akiban. For example:

drupal=> create table t1(id int not null);
CREATE TABLE
drupal=> comment on table t1 is 'this is a comment';
ERROR: [] com.akiban.sql.parser.ParseException: Encountered " <IDENTIFIER> "comment "" at line 1, column 1.
Was expecting one of:
    "alter" ...
    "begin" ...
    "commit" ...
    "create" ...
    "declare" ...
    "delete" ...
    "drop" ...
    "execute" ...
    "insert" ...
    "rollback" ...
    "select" ...
    "update" ...
    "values" ...
    "truncate" ...
    "call" ...
    "explain" ...
    "lock" ...
    "rename" ...
    "{" ...
    "(" ...
    "?" ...
    <DOLLAR_N> ...
    : comment on table t1 is 'this is a comment';
drupal=>

The syntax PostgreSQL uses for comments is defined here:

http://www.postgresql.org/docs/9.1/static/sql-comment.html

Revision history for this message
Ariel Weil (aweil) wrote :

We need to have a meeting to determine whether this is a simple addition during the Jenia timeframe or if we need to schedule it for the next release.

Changed in akiban-sql-parser:
status: New → Triaged
Changed in akiban-server:
status: New → Triaged
Changed in akiban-sql-parser:
importance: Undecided → Medium
Changed in akiban-server:
importance: Undecided → Medium
Changed in akiban-sql-parser:
assignee: nobody → Mike McMahon (mmcm)
Changed in akiban-server:
assignee: nobody → Jack Orenstein (jack-akiban)
Revision history for this message
Thomas Jones-Low (tjoneslo) wrote :

Comments for columns or tables require storage in the AIS. This requires an AIS change. There are a number of AIS changes scheduled for the next release.

We could parse and ignore the comments. But full support requires the AIS change.

Ariel Weil (aweil)
Changed in akiban-sql-parser:
milestone: none → future
Changed in akiban-server:
milestone: none → future
tags: added: indiedb
Ariel Weil (aweil)
Changed in akiban-server:
assignee: Jack Orenstein (jack-akiban) → Mike McMahon (mmcm)
Changed in akiban-sql-parser:
importance: Medium → Low
Changed in akiban-server:
importance: Medium → Low
tags: added: errata
information type: Private → Public
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers