Problem with "Automatically disconnect users who leave the hub"

[eMTee]

Bug created based on a question.

"It doesn't work. In the Hub / Connections column in the progress window it marks the user as Offline but he's still downloading and never get dissconnected.

What's wrong?"

[eMTee (realprogger)]

I've seen this problem before as well but I rarely leave hubs and usually don't have too much uploads either.
Fortunately I got the chance today to test this out as at the moment I am having two upload transfers, one ADC and one NMDC.
The function seems to be working well with the ADC transfer but definitely not with the NMDC one.

[eMTee (realprogger)]

There's a bug for both protocol regarding this function because in ADC the option isn't respected at all (always disconnects).

For NMDC it looks like the reason of the problem is that this option is checked in an onMinute event only to give a chance of reconnecting users not to loose their slots. But as in chunked downloads segments are often finished in less than a minute (since that is the target time in the automatic chunk size algorithm in dcpp / based clients) there's a lesser chance of disconnecting before the transfer is finished. So the function is working indefinitely, depending on timely conditions (e.g. it should work well with non-segmented uploads).

[iceman50 (bdcdevel)]

I just tested with r3123 the problem is still there I had to pull the context item for the user in TransferView and click disconnect (I came in the hub with a second client on a VPN and started the transfer) i left the hub with the second client and the transfer was still going (the 2nd client was not in any other hub where it could of connected through)