xs_write in mock_xenstore needs to strdup path

[Chris Behrens]

xs_write()'s path argument can be something on the stack from a caller which disappears before it is picked up when later processing.

This is the line in question:

n->path = path;

'n' gets added to the pending_notifications slist.. Later when xs_read_watch() is called... n->path is pointing to stack space that is gone. So, we need to strdup the path into n->path

[Chris Behrens (cbehrens)]

Also, same thing happens in xs_write() when storing ->token (and probably ->path)

[Chris Behrens (cbehrens)]

And fixing the munmap() being missing in read_from_spool_and_send_to_xen() reveals that xen_write_path->xs_write also stores 'buf'.. When you munmap() buf... The stored 'buf' in mock_xenstore points to bogus space.

So, obj->buf = buf; also needs to be fixed to malloc memory and memcpy.

[Chris Behrens (cbehrens)]

Attached patch will address after slist improvements are committed... otherwise there'll be a conflict.