Changing theme from Ambiance to SuruDark or SuruGradient in MainView's completion causes binding loops.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| address-book-app |
Undecided
|
Renato Araujo Oliveira Filho | ||
| address-book-app (Ubuntu) |
Undecided
|
Unassigned | ||
| ubuntu-ui-toolkit (Ubuntu) |
Medium
|
Zsombor Egri | ||
| Vivid |
Undecided
|
Unassigned | ||
| ubuntu-ui-toolkit (Ubuntu RTM) |
Undecided
|
Unassigned |
Bug Description
The following code snippet reproduces the error:
import QtQuick 2.0
import Ubuntu.Components 0.1
MainView {
width: units.gu(40)
height: units.gu(71)
Component.
}
Related branches
- PS Jenkins bot: Approve (continuous-integration) on 2014-03-14
- Arthur Mello (community): Approve on 2014-02-25
-
Diff: 23 lines (+5/-1)1 file modifiedsrc/imports/MainWindow.qml (+5/-1)
- Tim Peeters: Approve (quick look) on 2014-11-28
- Christian Dywan (community): Approve on 2014-11-27
-
Diff: 529 lines (+370/-21)16 files modifiedexamples/customtheme/customtheme.apparmor (+8/-0)
examples/customtheme/customtheme.desktop (+8/-0)
examples/customtheme/customtheme.qmlproject (+59/-0)
examples/customtheme/main.qml (+103/-0)
examples/customtheme/manifest.json (+15/-0)
examples/customtheme/theme/Palette.qml (+24/-0)
examples/customtheme/theme/parent_theme (+1/-0)
modules/Ubuntu/Components/MainView.qml (+16/-0)
modules/Ubuntu/Components/Themes/Ambiance/MainViewStyle.qml (+0/-17)
modules/Ubuntu/Components/plugin/uctheme.cpp (+4/-2)
tests/unit_x11/tst_components/tst_theming.qml (+60/-0)
tests/unit_x11/tst_theme_engine/AppTheme/Palette.qml (+24/-0)
tests/unit_x11/tst_theme_engine/AppTheme/parent_theme (+1/-0)
tests/unit_x11/tst_theme_engine/TestApp.qml (+29/-0)
tests/unit_x11/tst_theme_engine/tst_theme_engine.pro (+3/-1)
tests/unit_x11/tst_theme_engine/tst_theme_enginetest.cpp (+15/-1)
- PS Jenkins bot: Approve (continuous-integration) on 2014-12-05
- Christian Dywan (community): Approve on 2014-12-04
-
Diff: 518 lines (+368/-20)16 files modifiedexamples/customtheme/customtheme.apparmor (+8/-0)
examples/customtheme/customtheme.desktop (+8/-0)
examples/customtheme/customtheme.qmlproject (+59/-0)
examples/customtheme/main.qml (+103/-0)
examples/customtheme/manifest.json (+15/-0)
examples/customtheme/theme/Palette.qml (+24/-0)
examples/customtheme/theme/parent_theme (+1/-0)
modules/Ubuntu/Components/MainView.qml (+16/-0)
modules/Ubuntu/Components/Themes/Ambiance/MainViewStyle.qml (+0/-17)
modules/Ubuntu/Components/plugin/uctheme.cpp (+3/-1)
tests/unit_x11/tst_components/tst_theming.qml (+60/-0)
tests/unit_x11/tst_theme_engine/AppTheme/Palette.qml (+24/-0)
tests/unit_x11/tst_theme_engine/AppTheme/parent_theme (+1/-0)
tests/unit_x11/tst_theme_engine/TestApp.qml (+29/-0)
tests/unit_x11/tst_theme_engine/tst_theme_engine.pro (+3/-1)
tests/unit_x11/tst_theme_engine/tst_theme_enginetest.cpp (+14/-1)
Changed in address-book-app: | |
assignee: | nobody → Renato Araujo Oliveira Filho (renatofilho) |
Zsombor Egri (zsombi) wrote : | #1 |
Florian Boucault (fboucault) wrote : | #2 |
Please don't use that color value but instead the midAubergine from the colors constants:
http://
Changed in ubuntu-ui-toolkit: | |
status: | New → Confirmed |
Changed in address-book-app: | |
status: | New → Confirmed |
summary: |
- Changing theme from Ambiance to SuruDark or SuriGradient in MainView's + Changing theme from Ambiance to SuruDark or SuruGradient in MainView's completion causes binding loops. |
Please don't use that color value but instead the midAubergine from the colors constants.
Using this color causes the application to became purple.
I tried all colors on the colors constants and none of then works.
A greo on SDK code did not show any constant used for this color value "221E1C"
Florian Boucault (fboucault) wrote : | #4 |
Fair enough, we can hardcode the "221E1C" then. I don't remember why I thought midAubergine would do the trick.
Launchpad Janitor (janitor) wrote : | #5 |
This bug was fixed in the package address-book-app - 0.2+14.
---------------
address-book-app (0.2+14.
[ Ubuntu daily release ]
* New rebuild forced
[ Richard Huddie ]
* A new emulator method go_to_add_contact() to launch the add contact
screen, and a new test to validate its use.
[ Renato Araujo Oliveira Filho ]
* Refactory contact list. To switch between the favorite list and all
contacts list you will use the header.
* Refactory contact favorite selection. In this new version you
favorite the contact instead of phone number.
* Avoid change the "Theme.name" during the component complete, this
was causing a lot of properties binding loops. (LP: #1277647)
-- Ubuntu daily release <email address hidden> Tue, 18 Mar 2014 18:15:39 +0000
Changed in address-book-app (Ubuntu): | |
status: | New → Fix Released |
Changed in address-book-app: | |
status: | Confirmed → Fix Released |
Changed in messaging-app: | |
status: | New → Confirmed |
Christian Dywan (kalikiana) wrote : | #6 |
Messaging shouldn't actually use SuruGradient, see bug 1324484.
no longer affects: | messaging-app |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
importance: | Undecided → Medium |
status: | New → Confirmed |
no longer affects: | ubuntu-ui-toolkit |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
assignee: | nobody → Zsombor Egri (zsombi) |
Launchpad Janitor (janitor) wrote : | #7 |
This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1364+
---------------
ubuntu-ui-toolkit (1.1.1364+
[ Zsombor Egri ]
* Theming fixes: application theming, binding loop fix, auto-theming
moved into MainView and it is applicable only on Ambiance and
SuruDark, SuruGradient is no longer auto-themed.
Fixes: LP: #1213043, LP: #1277647, LP: #1330510, LP: #1356779,
LP: #1389792.
* ServiceProperties component to Ubuntu.Components 1.1.
Fixes: LP: #1391877.
* New ListItem component base. Support for leading/trailing actions.
Exported in Ubuntu.Components 1.2 UNSTABLE release.
Fixes: LP: #1097728, LP: #1372592, LP: #1383870.
* removing failing ServiceProperties and app-theming branches
* Application theming ant other theming related binding loop fixes
* ServiceProperties DBus property watcher
[ Christian Dywan ]
* Do the default theme check properly: for non-debug and without
build errors.
* Don't activate the control in ListItem.Standard implicitly.
Fixes: LP: #1372563.
* Improve AutoPilot caret dragging test cases.
* Use new qt_gl_set_
Fixes: LP: #1397979.
* Add sortCaseSensitivity to the SortFilterModel example.
Fixes: LP: #1391034.
* Change offending links into bold font. Fixes: LP: #1395011.
[ Daniel d'Andrada ]
* This is needed by unity8 for the "shell rotation" feature (ie
shell does all the rotation work instead of apps rotating
themselves). unity8's dialogs (like the power dialog when you
long press the power button) should follow its parent item
rotation and size, as one would expect, and not be sneakily
reparented to the scene root item, in which case the shell
UI would be rotated but its dialog would not.
Related bug LP: #1394511. Fixes: LP: #1394511.
[ Tim Peeters ]
* Remove the old header separator style. Fixes: LP: #1372590.
[ Loïc Molinari ]
* Made the UCAlarmPrivate destructor private.
[ Ubuntu daily release ]
* New rebuild forced
-- Ubuntu daily release <email address hidden> Tue, 09 Dec 2014 11:47:33 +0000
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Released |
As workaround set the backgroundColor of Mainview to SuruDark color ("#221E1C")