Changing theme from Ambiance to SuruDark or SuruGradient in MainView's completion causes binding loops.

Bug #1277647 reported by Zsombor Egri on 2014-02-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
address-book-app
Undecided
Renato Araujo Oliveira Filho
address-book-app (Ubuntu)
Undecided
Unassigned
ubuntu-ui-toolkit (Ubuntu)
Medium
Zsombor Egri
Vivid
Undecided
Unassigned
ubuntu-ui-toolkit (Ubuntu RTM)
Undecided
Unassigned

Bug Description

The following code snippet reproduces the error:

import QtQuick 2.0
import Ubuntu.Components 0.1

MainView {
    width: units.gu(40)
    height: units.gu(71)

    Component.onCompleted: Theme.name = "Ubuntu.Components.Themes.SuruDark"
}

Related branches

Changed in address-book-app:
assignee: nobody → Renato Araujo Oliveira Filho (renatofilho)
Zsombor Egri (zsombi) wrote :

As workaround set the backgroundColor of Mainview to SuruDark color ("#221E1C")

Florian Boucault (fboucault) wrote :

Please don't use that color value but instead the midAubergine from the colors constants:
http://developer.ubuntu.com/api/qml/sdk-14.04/Ubuntu.Components.UbuntuColors/#midAubergine-prop

Changed in ubuntu-ui-toolkit:
status: New → Confirmed
Changed in address-book-app:
status: New → Confirmed
Zsombor Egri (zsombi) on 2014-02-10
summary: - Changing theme from Ambiance to SuruDark or SuriGradient in MainView's
+ Changing theme from Ambiance to SuruDark or SuruGradient in MainView's
completion causes binding loops.

Please don't use that color value but instead the midAubergine from the colors constants.

Using this color causes the application to became purple.
I tried all colors on the colors constants and none of then works.
A greo on SDK code did not show any constant used for this color value "221E1C"

Florian Boucault (fboucault) wrote :

Fair enough, we can hardcode the "221E1C" then. I don't remember why I thought midAubergine would do the trick.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package address-book-app - 0.2+14.04.20140318.3-0ubuntu1

---------------
address-book-app (0.2+14.04.20140318.3-0ubuntu1) trusty; urgency=low

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Richard Huddie ]
  * A new emulator method go_to_add_contact() to launch the add contact
    screen, and a new test to validate its use.

  [ Renato Araujo Oliveira Filho ]
  * Refactory contact list. To switch between the favorite list and all
    contacts list you will use the header.
  * Refactory contact favorite selection. In this new version you
    favorite the contact instead of phone number.
  * Avoid change the "Theme.name" during the component complete, this
    was causing a lot of properties binding loops. (LP: #1277647)
 -- Ubuntu daily release <email address hidden> Tue, 18 Mar 2014 18:15:39 +0000

Changed in address-book-app (Ubuntu):
status: New → Fix Released
Changed in address-book-app:
status: Confirmed → Fix Released
Changed in messaging-app:
status: New → Confirmed
Christian Dywan (kalikiana) wrote :

Messaging shouldn't actually use SuruGradient, see bug 1324484.

no longer affects: messaging-app
Zoltan Balogh (bzoltan) on 2014-11-24
Changed in ubuntu-ui-toolkit (Ubuntu):
importance: Undecided → Medium
status: New → Confirmed
Zoltan Balogh (bzoltan) on 2014-11-24
no longer affects: ubuntu-ui-toolkit
Zsombor Egri (zsombi) on 2014-11-27
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Zsombor Egri (zsombi)
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1364+15.04.20141209-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1364+15.04.20141209-0ubuntu1) vivid; urgency=medium

  [ Zsombor Egri ]
  * Theming fixes: application theming, binding loop fix, auto-theming
    moved into MainView and it is applicable only on Ambiance and
    SuruDark, SuruGradient is no longer auto-themed.
    Fixes: LP: #1213043, LP: #1277647, LP: #1330510, LP: #1356779,
           LP: #1389792.
  * ServiceProperties component to Ubuntu.Components 1.1.
    Fixes: LP: #1391877.
  * New ListItem component base. Support for leading/trailing actions.
    Exported in Ubuntu.Components 1.2 UNSTABLE release.
    Fixes: LP: #1097728, LP: #1372592, LP: #1383870.
  * removing failing ServiceProperties and app-theming branches
  * Application theming ant other theming related binding loop fixes
  * ServiceProperties DBus property watcher

  [ Christian Dywan ]
  * Do the default theme check properly: for non-debug and without
    build errors.
  * Don't activate the control in ListItem.Standard implicitly.
    Fixes: LP: #1372563.
  * Improve AutoPilot caret dragging test cases.
  * Use new qt_gl_set_global_share_context setter with Qt 5.4.
    Fixes: LP: #1397979.
  * Add sortCaseSensitivity to the SortFilterModel example.
    Fixes: LP: #1391034.
  * Change offending links into bold font. Fixes: LP: #1395011.

  [ Daniel d'Andrada ]
  * This is needed by unity8 for the "shell rotation" feature (ie
    shell does all the rotation work instead of apps rotating
    themselves). unity8's dialogs (like the power dialog when you
    long press the power button) should follow its parent item
    rotation and size, as one would expect, and not be sneakily
    reparented to the scene root item, in which case the shell
    UI would be rotated but its dialog would not.
    Related bug LP: #1394511. Fixes: LP: #1394511.

  [ Tim Peeters ]
  * Remove the old header separator style. Fixes: LP: #1372590.

  [ Loïc Molinari ]
  * Made the UCAlarmPrivate destructor private.

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Tue, 09 Dec 2014 11:47:33 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers