Forbidden commands in ADC
Bug #1189975 reported by
maksis
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ADCH++ |
New
|
Undecided
|
Unassigned | ||
ADCH++ Lan |
New
|
Critical
|
Francisco Blas Izquierdo Riera (klondike) | ||
DC++ |
Fix Released
|
High
|
Unassigned |
Bug Description
When DC++ receives a STA message with code 25, it adds the command in to the list of forbidden outgoing commands. However, the client doesn't check that the STA message originates from the hub, so any other client could send malicious STA messages and prevent DC++ from sending any outgoing command via the hub. The fix is rather trivial.
I generally dislike the way how code 25 is handled, as DC++ doesn't notify the user when it blocks a command and neither when an outgoing command is disregarded right before sending.
To post a comment you must log in.
I can write a simple script to block these on ADCH++, has any of you managed to confirm this?