privacy settings: remove history datetimepicker not working

[Vincent Thiele]

[Impact]
User is unable to use calendar widgets when clearing history - they do not respond to mouse clicks.

[Test Case]
1. Open System Settings.
2. Select "Security & Privacy"
3. Select "Files & Applications" tab
4. Select "Clear Usage Data..."
5. Click dropdown beside one of the date widgets

Expected result:
A calendar is shown and a date can be selected.

Observed result:
The calendar is shown, but is greyed out and doesn't respond to clicks. The calendar doesn't disappear until System Settings is closed.

[Regression Potential]
Low. Fix makes widgets work correctly with modal dialogs. Regressions are likely to be contained to these widgets which are not working correctly currently.

[Robert Ancell (robert-ancell)]

The panel is provided by activity-log-manager

[Robert Ancell (robert-ancell)]

The problem seems to be that the custom calendar widget doesn't correctly do input grabs and this means it doesn't get input when the dialog is modal. If the dialog is set to non-modal it works fine but the dialog can remain even once the panel is closed.

I've been trying to make the calendar widget work correctly by copying GtkComboBox and GtkPopover but haven't got it to work.

[Vincent Thiele (vincentthiele)]

Any updates? How about removing calendar widget an allowing manual input via textbox?

[Vincent Thiele (vincentthiele)]

Issue is still there on xenial...

[Vincent Thiele (vincentthiele)]

I've attached a patch, which I tested on ubuntu 14.04. Please review and add!

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "activity-log-manager.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Yaroslav Chagovets (yaroslav-chagovets)]

I confirm that the issue affects Ubuntu 16.04. Dear Ubuntu maintainers, please review the patch above.

[Łukasz Zemczak (sil2100)]

Hello! I would first like someone with proper activity-log-manager experience to review the change before sponsoring - Robert, could you maybe check the patch on comment #6 ? Also, could we get this change proposed as a merge-request against lp:activity-log-manager ? This way we'll be sure this doesn't get lost upstream and will give us proper options to get the change reviewed before release.

[Robert Ancell (robert-ancell)]

Thanks Vincent for the work!

This patch contained three fixes:
1. Fix the calendars not being selectable.
2. Fix the location of the warning label on invalid range.
3. Change the selection of a date from a double click to a single click.

I've pushed changes for the first two to lp:activity-log-manager. The change from a double click to a single click is a matter of opinion that is probably better tracked in a separate bug (the whole dialog could do with some UI love).

[Launchpad Janitor (janitor)]

This bug was fixed in the package activity-log-manager - 0.9.7-0ubuntu25

---------------
activity-log-manager (0.9.7-0ubuntu25) zesty; urgency=medium

  * debian/patches/21_clear_history_calendars.patch:
    - Fix calendars not working when selecting date range to clear
      (LP: #1303508)

 -- Robert Ancell <email address hidden> Fri, 24 Mar 2017 10:56:02 +1300

[Łukasz Zemczak (sil2100)]

Hello Robert! Thanks for reviewing the patches! I'll be accepting your SRU uploads for this change but with a small difference - I'll be changing the versioning a bit as I prefer the usual .1/.16.10.1 scheme instead. No worries, I'll handle this on my side.

[Łukasz Zemczak (sil2100)]

Hello Vincent, or anyone else affected,

Accepted activity-log-manager into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/activity-log-manager/0.9.7-0ubuntu23.16.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Łukasz Zemczak (sil2100)]

Hello Vincent, or anyone else affected,

Accepted activity-log-manager into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/activity-log-manager/0.9.7-0ubuntu23.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Łukasz Zemczak (sil2100)]

Hello Vincent, or anyone else affected,

Accepted activity-log-manager into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/activity-log-manager/0.9.7-0ubuntu14.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Robert Ancell (robert-ancell)]

Confirmed test case now works in trusty, xenial and yakkety.

[Launchpad Janitor (janitor)]

This bug was fixed in the package activity-log-manager - 0.9.7-0ubuntu14.2

---------------
activity-log-manager (0.9.7-0ubuntu14.2) trusty; urgency=medium

  * debian/patches/17_clear_history_calendars.patch:
    - Fix calendars not working when selecting date range to clear
      (LP: #1303508)

 -- Robert Ancell <email address hidden> Fri, 24 Mar 2017 10:56:02 +1300

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for activity-log-manager has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package activity-log-manager - 0.9.7-0ubuntu23.16.04.1

---------------
activity-log-manager (0.9.7-0ubuntu23.16.04.1) xenial; urgency=medium

  * debian/patches/21_clear_history_calendars.patch:
    - Fix calendars not working when selecting date range to clear
      (LP: #1303508)

 -- Robert Ancell <email address hidden> Fri, 24 Mar 2017 10:56:02 +1300

[Launchpad Janitor (janitor)]

This bug was fixed in the package activity-log-manager - 0.9.7-0ubuntu23.16.10.1

---------------
activity-log-manager (0.9.7-0ubuntu23.16.10.1) yakkety; urgency=medium

  * debian/patches/21_clear_history_calendars.patch:
    - Fix calendars not working when selecting date range to clear
      (LP: #1303508)

 -- Robert Ancell <email address hidden> Fri, 24 Mar 2017 10:56:02 +1300