lp:~c-lobrano/snappy/hw-assign-fix-overwrite-udev-rule

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~snappy-dev/snappy/snappy-moved-to-github at revision 718

John Lenton (community): Approve on 2015-09-25

Diff: 159 lines (+87/-9)

3 files modified

.bzrignore (+3/-0)
snappy/hwaccess.go (+71/-9)
snappy/hwaccess_test.go (+13/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1497299: hw-assign overwrites existing udev rules

Critical

Fix Released

Link a bug report

Related blueprints

719. By Carlo Lobrano on 2015-09-25

fixes lp:1497299

718. By Carlo Lobrano on 2015-09-25

Fix removeUdevRuleForSnap file opening

717. By Carlo Lobrano on 2015-09-25

Optimized addUdevRuleForSnap method

Remove call to os.OpenFile and use ioutil.ReadFile directly
to check for the udev rule file existence.

716. By Carlo Lobrano on 2015-09-25

Changes according to John Lenton (Chipaca)'s code review

- Fix creation of the new udev rule file for snap
- Fix coding rules violations

715. By Carlo Lobrano on 2015-09-24

Commit changes according to code review

714. By Carlo Lobrano on 2015-09-22

Merge last changes

713. By Carlo Lobrano on 2015-09-22

Update hw-unassign according to changes for fix Bug #1497299

hw-unassign just delete the snap's udev rule file, even when more than one
rule is present. Due to Bug #1497299 udev rule file could not contain
more than one rule at a time, so the problem has never pop out.

Fix the above problem adding UpdateUdevRuleForSnapp function that:

- acquire the list of the Udev rules to keep, namely not related to the to-be-unassigned device node
- delete the current snap's udev rule file
- create a new snap's udev rule file with the rules at the first point

712. By Carlo Lobrano on 2015-09-19

Fix for Bug #1497299

Open the Snap's udev rule in append mode, in place of writing a new file each time hw-assign is called.

Note: hw-unassign deletes the entire snap's udev rule file when called.

711. By Launchpad Translations on behalf of snappy-dev on 2015-09-19

Launchpad automatic translations update.

710. By Michael Vogt on 2015-09-18

Add new "snappy shell" command. by mvo approved by mvo,chipaca