bcmwl builds with Kernel 5.17 w/ one small patch

[satmandu]

At the very minimum, 5.17 replaces PDE_DATA with pde_data as per https://<email address hidden>/T/#u

The attached patch addresses that issue, but the module still doesn't work...

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: bcmwl-kernel-source 6.30.223.271+bdcom-0ubuntu8
Uname: Linux 5.16.10-051610-generic x86_64
NonfreeKernelModules: wl zfs zunicode zcommon znvpair zavl icp
ApportVersion: 2.20.11-0ubuntu77
Architecture: amd64
CasperMD5CheckResult: unknown
CurrentDesktop: ubuntu:GNOME
Date: Tue Feb 22 09:24:44 2022
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: bcmwl
UpgradeStatus: No upgrade log present (probably fresh install)

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "Fix PDE_DATA change in 5.17" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[satmandu (satadru-umich)]

This is the kernel issue I get with the expanded patch.

[ 7.508238] ------------[ cut here ]------------
[ 7.508239] netdevice: wlp3s0: Incorrect netdev->dev_addr
[ 7.508257] WARNING: CPU: 3 PID: 1710 at net/core/dev_addr_lists.c:517 dev_addr_check.cold+0x65/0x9f
[ 7.508267] Modules linked in: cmac algif_hash algif_skcipher af_alg bnep nls_iso8859_1 intel_rapl_msr intel_rapl_common joydev mei_hdcp mei_pxp x86_pkg_temp_thermal intel_powerclamp coretemp snd_hda_codec_cirrus snd_hda_codec_generic applesmc snd_hda_codec_hdmi ledtrig_audio snd_hda_intel snd_intel_dspcfg snd_intel_sdw_acpi btusb snd_hda_codec btrtl snd_hda_core kvm_intel btbcm btintel snd_hwdep btmtk snd_pcm kvm bluetooth ecdh_generic snd_seq_midi snd_seq_midi_event ecc rapl wl(POE) snd_rawmidi input_leds snd_seq bcm5974 intel_cstate snd_seq_device sbs snd_timer apple_mfi_fastcharge cfg80211 snd mei_me acpi_als industrialio_triggered_buffer efi_pstore mei kfifo_buf soundcore sbshc industrialio apple_gmux mac_hid apple_bl sch_fq_codel ipmi_devintf ipmi_msghandler msr parport_pc ppdev lp parport ip_tables x_tables autofs4 zfs(POE) zunicode(POE) zzstd(OE) zlua(OE) zcommon(POE) znvpair(POE) zavl(POE) icp(POE) spl(OE) hid_apple hid_generic uas ax88179_178a usbhid usbnet usb_storage hid mii
[ 7.508367] nouveau mxm_wmi wmi i2c_algo_bit drm_ttm_helper ttm drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel crypto_simd cryptd cec nvme rc_core nvme_core i2c_i801 thunderbolt drm i2c_smbus lpc_ich xhci_pci xhci_pci_renesas video
[ 7.508399] CPU: 3 PID: 1710 Comm: NetworkManager Tainted: P OE 5.17.0-051700rc5-generic #202202202230
[ 7.508403] Hardware name: Apple Inc. MacBookPro11,3/Mac-2BD1B31983FE1663, BIOS 432.60.3.0.0 10/27/2021
[ 7.508405] RIP: 0010:dev_addr_check.cold+0x65/0x9f
[ 7.508411] Code: 01 e8 9e 2b f6 ff 0f 0b 49 c7 c4 81 9e 83 aa 80 3b 00 75 30 48 c7 c6 8c 9e 83 aa 4c 89 e2 48 c7 c7 90 5c 8d aa e8 7a 2b f6 ff <0f> 0b e9 8d c8 d5 ff 4c 8b 24 c5 a0 c5 52 aa eb d4 49 c7 c4 81 9e
[ 7.508414] RSP: 0018:ffffbb2287f5b380 EFLAGS: 00010282
[ 7.508417] RAX: 0000000000000000 RBX: ffff98f4810dd000 RCX: 0000000000000027
[ 7.508419] RDX: ffff98f7ef2e0988 RSI: 0000000000000001 RDI: ffff98f7ef2e0980
[ 7.508422] RBP: ffffbb2287f5b390 R08: 0000000000000003 R09: fffffffffffd4a88
[ 7.508424] R10: ffffffffffffffff R11: 0000000000000001 R12: ffffffffaa7e7338
[ 7.508425] R13: ffffffffc12fa460 R14: 0000000000000001 R15: ffff98f4810dd000
[ 7.508428] FS: 00007f579d7664c0(0000) GS:ffff98f7ef2c0000(0000) knlGS:0000000000000000
[ 7.508431] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 7.508433] CR2: 0000560784eca498 CR3: 000000010bc26006 CR4: 00000000001706e0
[ 7.508436] Call Trace:
[ 7.508438] <TASK>
[ 7.508443] __dev_open+0x45/0x1c0
[ 7.508451] ? nvme_pci_setup_prps+0xe5/0x340 [nvme]
[ 7.508459] __dev_change_flags+0x1a3/0x220
[ 7.508465] ? wlc_iovar_check+0x152/0x21b [wl]
[ 7.508548] dev_change_flags+0x26/0x60
[ 7.508553] do_setlink+0x28a/0xc60
[ 7.508560] ? __nla_parse+0x25/0x30
[ 7.508566] ? cpumask_next+0x23/0x30
[ ...

[satmandu (satadru-umich)]

(Worth noting that is a warning, and the network still works.)

[satmandu (satadru-umich)]

This happens because of https://github.com/torvalds/linux/commit/adeef3e32146a8d2a73c399dc6f5d76a449131b1

netdev->dev_addr is a const now...

[satmandu (satadru-umich)]

The patch at https://gist.github.com/joanbm/37fd0590f30b41e7e89ade6e242ca16e from Joan Bruguera <email address hidden> completely solves the issue. (Patch is attached.)