Keyboard termination prints a stack trace when ctl+c is pressed soon.

Bug #1157905 reported by John Bresnahan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
Undecided
John Bresnahan

Bug Description

The previous bug: https://bugs.launchpad.net/python-glanceclient/+bug/1130390 began to solve this issue but the try/except block for KeyboardInterupt was too deeply nested in the code. Thus a user can hit Ctl+C during keystone communication and get a traceback as output. This can be easily solved by moving the try/except block to the top level.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24923

Changed in python-glanceclient:
assignee: nobody → John Bresnahan (jbresnah)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/24923
Committed: http://github.com/openstack/python-glanceclient/commit/edf9ae509763a70c7cd72e79c8c3896b903981e3
Submitter: Jenkins
Branch: master

commit edf9ae509763a70c7cd72e79c8c3896b903981e3
Author: John Bresnahan <email address hidden>
Date: Wed Mar 20 08:51:59 2013 -1000

    Trapping KeyboardInterrupt sooner.

    Currently a KeyboardInterrupt can be triggered by the user while the
    client is communicating with keystone. This patch moves the trap
    higher up in the stack.

    Fixes bug: 1157905

    Change-Id: I16889c2d97bc4694ab27c863c62c27333e264b60

Changed in python-glanceclient:
status: In Progress → Fix Committed
Louis Taylor (kragniz)
Changed in python-glanceclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.