Unable to list the volume type by volumetype name caused by unrecognizaed search_opts

Bug #1252665 reported by Vincent Hou
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
Undecided
Avishay Traeger

Bug Description

I have found a minor feature regression recently.
We can create a volume type via the command cinder type-create **** and then create a key via cinder type-key key_name set key=value. key_name could either be a type id or the type name.
Since the method base.ManagerWithFind.findall has been modified by adding the the search_opts for all tenants support, the parameter search_opts should also be added to all the manager classes, which can be called whithin this method. volumetypemanager does not have this parameter forits method list(), so type id works for cinder type-key command, but neither does type name.

Vincent Hou (houshengbo)
Changed in cinder:
assignee: nobody → Vincent Hou (houshengbo)
description: updated
Revision history for this message
Vincent Hou (houshengbo) wrote :
affects: cinder → python-cinderclient
Changed in python-cinderclient:
assignee: Vincent Hou (houshengbo) → Avishay Traeger (avishay-il)
status: New → In Progress
Changed in python-cinderclient:
assignee: Avishay Traeger (avishay-il) → Vincent Hou (houshengbo)
Changed in python-cinderclient:
assignee: Vincent Hou (houshengbo) → Avishay Traeger (avishay-il)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/57404
Committed: http://github.com/openstack/python-cinderclient/commit/e64973f9a70fba10b25645c74454fc3d744568bf
Submitter: Jenkins
Branch: master

commit e64973f9a70fba10b25645c74454fc3d744568bf
Author: Vincent Hou <email address hidden>
Date: Wed Nov 20 04:34:38 2013 -0500

    Add search_opts into the method list() for VolumeTypeManager

    Since the method base.ManagerWithFind.findall has been modified by
    adding the search_opts for all tenants support, the parameter
    search_opts should also be added to all the manager classes, which
    can be called whithin this method. volumetypemanager does not have
    this parameter for its method list(). Adding search_opts will resolve
    this issue.

    Closes-Bug: #1252665

    Change-Id: I526500625f1b5483cb5d88ea15e6ac8485a66ae3

Changed in python-cinderclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-cinderclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/67780

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/67780
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=2f0863b7d4d20198f496534d5ffef85e68ff45fc
Submitter: Jenkins
Branch: master

commit 2f0863b7d4d20198f496534d5ffef85e68ff45fc
Author: Xiao Chen <email address hidden>
Date: Mon Jan 20 15:29:55 2014 +0800

    Fix 'search_opts' unexpected keyword argument error

    When executing 'encryption-type-create' command using resource
    name, it will use the findall() in base.py, then error will
    occur because list() in findall() used 'search_opts' argument
    which list() in VolumeEncryptionTypeManager did not have. Some
    other command like 'transfer-delete' met same issue.

    This patch will add 'search_opts' argument in list() function
    in child class to avoid the bug.

    Closes-Bug: #1248519
    Related-Bug: #1252665

    Change-Id: If1cd8b812af21335e5d4351766539a927a8fbdf4

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-cinderclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/178588

no longer affects: python-openstackclient
Changed in python-cinderclient:
milestone: none → 1.3.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.