Got ERROR: 'bool' object has no attribute 'lower' when create volume snapshot

[Zhikun Liu]

Tested on Devstack.

# cinder --debug snapshot-create 173fe39c-9603-4cac-bc13-2bb990ed8df9
snap..
DEBUG (shell:523) 'bool' object has no attribute 'lower'
Traceback (most recent call last):
  File "/opt/stack/python-cinderclient/cinderclient/shell.py", line 518, in main
    sys.argv[1:]))
  File "/opt/stack/python-cinderclient/cinderclient/shell.py", line 464, in main
    args.func(self.cs, args)
  File "/opt/stack/python-cinderclient/cinderclient/v1/shell.py", line 424, in do_snapshot_create
    if not args.force.lower() in ['true', '1', 'yes', 'y',
AttributeError: 'bool' object has no attribute 'lower'
ERROR: 'bool' object has no attribute 'lower'

[Cory Stone (corystone)]

args.force defaults to a boolean.

https://review.openstack.org/#/c/38002/ added string operations on said boolean.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/39960

[John Griffith (john-griffith)]

Yeah, actually IMO I should've caught that and -2'd the change. I'm also not crazy about allowing any string as the input and modifying it.

[John Griffith (john-griffith)]

I've proposed a revert of the offending patch [1]. We can fix this the correct way by using strutils.bool_from_string() to address bug [2]

I'll mark this as invalid as a result, and update the original as still needing fixed.

[1] https://review.openstack.org/#/c/38002/

[2] https://bugs.launchpad.net/nova/+bug/1014689

[Rushi Agrawal (rushiagr)]

Sorry, but I can't reproduce this on latest cinder, so marking it as invalid. Please reopen if you can reproduce this, along with steps to reproduce if different from the original bug message..