non-ASCII volume display name breaks 'cinder show'

Bug #1130572 reported by Flavio Percoco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
Undecided
Flavio Percoco

Bug Description

After creating a volume with a display name that includes non-ASCII characters, you can not get the details of the volume by name using 'cinder show'.

More details here: https://bugzilla.redhat.com/show_bug.cgi?id=888952

Changed in python-cinderclient:
assignee: nobody → Flavio Percoco Premoli (flaper87)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23089

Changed in python-cinderclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/23089
Committed: http://github.com/openstack/python-cinderclient/commit/03a4806d972ac150e717451566e9c4c35a141d8f
Submitter: Jenkins
Branch: master

commit 03a4806d972ac150e717451566e9c4c35a141d8f
Author: Flaper Fesp <email address hidden>
Date: Wed Feb 27 14:47:44 2013 +0100

    Decodes input and encodes output

    Currently cinderclient doesn't handle properly incoming and outgoing
    encode / decode process. As a solution for this, this patch implements a
    decoding process for all data incoming from the user side and encodes
    everything going out of the client, i.e: http requests, prints, etc.

    This patch introduces a new module (strutils.py) taken from
    oslo-incubator in order to use 2 of the functions present in it:

    About safe_(decode|encode):

        Both functions try to encode / decode the incoming text using the
        stdin encoding, fallback to python's default encoding if that
        returns None or to UTF-8 as the last option.

        In both functions only basestring objects are accepted and they both
        raise TypeError if an object of another type is passed.

    About the general cinderclient changes:

        In order to better support non-ASCII characters, it is a good
        practice to use unicode interanlly and encode everything that has to
        go out. This patch aims to do that and introduces this behaviour in
        the client.

    Testing:

        A good test (besides using tox) is to use cinder client with and
        without setting any locale (export LANG=).

    Fixes bug: 1130572

    Change-Id: Idb7d06954c29e003f68a0c4aa0b80ecc7017cbc9

Changed in python-cinderclient:
status: In Progress → Fix Committed
Changed in python-cinderclient:
milestone: none → 1.3.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.