Tar4ibd silently fails to send entire backup

Bug #690822 reported by Lee Faris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona XtraBackup moved to https://jira.percona.com/projects/PXB
Fix Released
Critical
Stewart Smith

Bug Description

tar4ibd will silently fail to send the entire contents of a large file if tar4ibd was compiled with a size_t of unsigned int. The function will succeed because 'enough' data was sent.

Since th_get_size() was redefined to return a long long in the tar4ibd patch the 'size' variable also needs to be a long long. Patch is included.

Tags: tar4ibd

Related branches

Revision history for this message
Lee Faris (leelynnef) wrote :
Revision history for this message
Yasufumi Kinoshita (yasufumi-kinoshita) wrote :

Thank you.
The patch is needed for 32bit system to treat large file.

Changed in percona-xtrabackup:
status: New → Confirmed
assignee: nobody → Alexey Kopytov (akopytov)
importance: Undecided → Medium
milestone: none → 1.6
Changed in percona-xtrabackup:
status: Confirmed → New
assignee: Alexey Kopytov (akopytov) → Valentine Gostev (core-longbow)
Changed in percona-xtrabackup:
milestone: 1.6 → 1.7
tags: added: tar4ibd
Revision history for this message
Valentine Gostev (longbow) wrote :

Lee,

can you please specify the version of OS where you met this bug, and what command was used.

Revision history for this message
Lee Faris (leelynnef) wrote :

I used a 32 bit RHEL5 OS. The command was make which compiled tar with gcc 4.1.2. You should only see this bug on 32 bit systems.

Revision history for this message
Stewart Smith (stewart) wrote :

Confirmed from examining source.

We should increase testing on large datasets on 32bit though (Valentine please create blueprint)

This is actually a bug in upstream libtar.

Changed in percona-xtrabackup:
status: New → Confirmed
importance: Medium → Critical
assignee: Valentine Gostev (core-longbow) → Stewart Smith (stewart)
Revision history for this message
Stewart Smith (stewart) wrote :

( by bug in upstream libtar I mean that it's missing a bunch of our libtar patch that would make this problem a bit more obvious)

Changed in percona-xtrabackup:
status: Confirmed → Fix Committed
Stewart Smith (stewart)
Changed in percona-xtrabackup:
status: Fix Committed → Fix Released
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-211

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.